planner: add doc for tidb_ignore_inlist_plan_digest.
#20870
Conversation
qiancai
added
area/planner
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a new file named temp.md containing the text "This is a test file.". The purpose of this addition is not explicitly stated in the provided information, but based on the file content, it seems to be for testing purposes.
Highlights
- New File Creation: A new Markdown file named
temp.mdhas been created. - Content Addition: The file
temp.mdcontains the simple text "This is a test file."
Changelog
- temp.md
- Created a new file with the content 'This is a test file.'
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/XS
There was a problem hiding this comment.
Code Review
The pull request adds a test file. The change itself is simple, but I'll review it to ensure it aligns with the project's documentation guidelines and style.
Merge Readiness
The pull request introduces a new test file. Given the simplicity of the change, it appears to be mergeable. However, I am unable to directly approve the pull request, and other reviewers should also examine the code before merging. Since there are no critical or high severity issues, the pull request can be merged after addressing the low severity comments.
ti-chi-bot
bot
added
size/S
qiancai
added
needs-cherry-pick-release-8.1
system-variables.md
Outdated
| - This variable controls whether TiDB ignores the element differences in the `IN` list across different queries when generating Plan Digests. | ||
|
|
||
| - When it is the default value `OFF`, TiDB ignores the element differences in the `IN` list (including the difference in the number of elements) when generating Plan Digests. | ||
| - When it is set to `ON`, TiDB includes the elements (as well as the number of elements) in the `IN` list as part of Plan Digests. The element differences in the `IN` list result in different Plan Digests. |
system-variables.md
Outdated
| - Default value: `OFF` | ||
| - This variable controls whether TiDB ignores the element differences in the `IN` list across different queries when generating Plan Digests. | ||
|
|
||
| - When it is the default value `OFF`, TiDB ignores the element differences in the `IN` list (including the difference in the number of elements) when generating Plan Digests. |
There was a problem hiding this comment.
off 应该是不忽略，所以不同的 inlist 会导致不同的 digest
|
@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
…fts-1 * commit 'c3ec7513da16bfb6c84af93213c0006040dbd867': ticdc: add [[filter.event-filters]] to the toml example (#20921) (#20925) Add tidb index usage limitation for valid stats (#20833) (#20912) tidb-cloud: update LOAD DATA INFILE description (#20917) (#20918) Update pad attribute where needed (#20823) (#20910) Add restriction for IMPORT INTO regarding empty (#20562) (#20908) tikv: recorrect the settings of some configs and supplement missing annotations for several configs. (#20871) (#20899) planner: add doc for `tidb_ignore_inlist_plan_digest`. (#20870) (#20890) JDBC URL: update the letter case for defaultFetchSize (#20884) (#20887) fix(pd): add missing configuration items for PD (#20883) (#20894) hardware-and-software-requirements: update Kylin Euler to Kylin (#20874) (#20881) add FAQs about collation for JDBC connections (#20848) (#20869) pd configuration: add dashboard.disable-custom-prom-addr (#20853) (#20857) releases: add one br entry to v8.1.2 (#20861) (#20864) toc: add TiDB release support policy (#19119) (#20859)
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
tidb_ignore_inlist_plan_digest. docs-cn#20267Do your changes match any of the following descriptions?