planner: add doc for tidb_ignore_inlist_plan_digest. (#20870) (#20890)
#20900
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
area/planner
|
@ti-chi-bot This PR has conflicts, I have hold it. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request is an automated cherry-pick of #20870 and #20890, adding documentation for the tidb_ignore_inlist_plan_digest system variable in the releases/release-7.6.0.md file. This variable controls whether TiDB ignores element differences in the IN list when generating Plan Digests.
Highlights
- Documentation: Adds documentation for the
tidb_ignore_inlist_plan_digestsystem variable to the release notes. - System Variable: Documents the behavior of the
tidb_ignore_inlist_plan_digestsystem variable, which controls how TiDB handlesINlist differences in Plan Digests.
Changelog
- releases/release-7.6.0.md
- Added documentation for the
tidb_ignore_inlist_plan_digestsystem variable. - Clarified that this variable controls whether TiDB ignores element differences in the
INlist across different queries when generating Plan Digests. - Specified that the default value of
tidb_ignore_inlist_plan_digestisOFF, meaning differences are not ignored.
- Added documentation for the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
size/XS
There was a problem hiding this comment.
Code Review
The pull request adds documentation for the tidb_ignore_inlist_plan_digest system variable. The changes look straightforward and necessary for informing users about this new feature.
Merge Readiness
The pull request appears to be ready for merging, as it simply adds documentation for a new system variable. There are no apparent issues that would prevent merging. I am unable to directly approve the pull request, and it should be reviewed by others before merging.
|
@gemini-code-assist[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
qiancai
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
This is an automated cherry-pick of #20890
This is an automated cherry-pick of #20870
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
tidb_ignore_inlist_plan_digest. docs-cn#20267Do your changes match any of the following descriptions?