Update pad attribute where needed (#20823) #20910
Conversation
Co-authored-by: Grace Cai <qqzczy@126.com>
ti-chi-bot
added
lgtm
size/M
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the documentation to reflect the addition of the PAD_ATTRIBUTE column to the output of SHOW COLLATION and the INFORMATION_SCHEMA.COLLATIONS table. This column indicates whether trailing spaces are ignored during string comparison for a given collation. The changes affect the character-set-and-collation.md, information-schema/information-schema-collations.md, and sql-statements/sql-statement-show-collation.md files.
Highlights
- Documentation Update: The documentation is updated to include the
PAD_ATTRIBUTEcolumn in the output ofSHOW COLLATIONandINFORMATION_SCHEMA.COLLATIONS. - PAD_ATTRIBUTE Explanation: The
PAD_ATTRIBUTEcolumn indicates whether trailing spaces are ignored during string comparison for a given collation.PAD SPACEmeans trailing spaces are ignored, whileNO PADmeans they are significant.
Changelog
- character-set-and-collation.md
- The output example of
SHOW COLLATIONis updated to include thePad_attributecolumn and its possible values (PAD SPACEandNO PAD).
- The output example of
- information-schema/information-schema-collations.md
- The table schema for
INFORMATION_SCHEMA.COLLATIONSis updated to include thePAD_ATTRIBUTEcolumn. - The output example of
SELECT * FROM collations WHERE character_set_name='utf8mb4';is updated to include thePAD_ATTRIBUTEcolumn and its possible values. - A description of the
PAD_ATTRIBUTEcolumn is added, explaining its meaning and possible values.
- The table schema for
- sql-statements/sql-statement-show-collation.md
- The output example of
SHOW COLLATIONis updated to include thePad_attributecolumn and its possible values (PAD SPACEandNO PAD).
- The output example of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the documentation to include the Pad_attribute column in the SHOW COLLATION output and provides explanations for its values. The changes seem accurate and improve the documentation's completeness. The style guide was followed, and the changes are well-organized.
Merge Readiness
The pull request appears to be well-written and addresses a specific documentation gap. The changes are clear and follow the provided style guide. I am unable to approve this pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues, so the pull request is likely ready to be merged after another review.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…fts-1 * commit 'c3ec7513da16bfb6c84af93213c0006040dbd867': ticdc: add [[filter.event-filters]] to the toml example (#20921) (#20925) Add tidb index usage limitation for valid stats (#20833) (#20912) tidb-cloud: update LOAD DATA INFILE description (#20917) (#20918) Update pad attribute where needed (#20823) (#20910) Add restriction for IMPORT INTO regarding empty (#20562) (#20908) tikv: recorrect the settings of some configs and supplement missing annotations for several configs. (#20871) (#20899) planner: add doc for `tidb_ignore_inlist_plan_digest`. (#20870) (#20890) JDBC URL: update the letter case for defaultFetchSize (#20884) (#20887) fix(pd): add missing configuration items for PD (#20883) (#20894) hardware-and-software-requirements: update Kylin Euler to Kylin (#20874) (#20881) add FAQs about collation for JDBC connections (#20848) (#20869) pd configuration: add dashboard.disable-custom-prom-addr (#20853) (#20857) releases: add one br entry to v8.1.2 (#20861) (#20864) toc: add TiDB release support policy (#19119) (#20859)
This is an automated cherry-pick of #20823
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
pingcap/tidb#54250
Do your changes match any of the following descriptions?