Skip to content

tikv: recorrect the settings of some configs and supplement missing annotations for several configs. #20871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 28, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

As the title mentioned, this PR is used to recorrect the settings for some configurations in TiKV.

Meanwhile, for some newly introduced configurations, it supplements annotations for them.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Apr 28, 2025
Copy link

Note

The files in this pull request are not supported by Gemini Code Assist.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2025
@qiancai qiancai self-assigned this Apr 29, 2025
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 29, 2025

/cc @LykxSassinator

Copy link

ti-chi-bot bot commented Apr 29, 2025

@qiancai: GitHub didn't allow me to request PR reviews from the following users: LykxSassinator.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @LykxSassinator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 30, 2025
Copy link

ti-chi-bot bot commented Apr 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-30 02:46:08.503455695 +0000 UTC m=+1014912.315246061: ☑️ agreed by Oreoxmt.

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 30, 2025

/approve

@qiancai qiancai added the lgtm label Apr 30, 2025
Copy link

ti-chi-bot bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 30, 2025
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 30, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit a5b3f19 into pingcap:master Apr 30, 2025
8 of 9 checks passed
@qiancai qiancai added ONCALL Relates to documentation oncall. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. labels Apr 30, 2025
@qiancai qiancai added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Apr 30, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20896.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 30, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 30, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20897.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 30, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20898.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20899.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2025
breezewish added a commit that referenced this pull request May 8, 2025
…fts-1

* commit 'c3ec7513da16bfb6c84af93213c0006040dbd867':
  ticdc: add [[filter.event-filters]] to the toml example (#20921) (#20925)
  Add tidb index usage limitation for valid stats (#20833) (#20912)
  tidb-cloud: update LOAD DATA INFILE description (#20917) (#20918)
  Update pad attribute where needed (#20823) (#20910)
  Add restriction for IMPORT INTO regarding empty (#20562) (#20908)
  tikv: recorrect the settings of some configs and supplement missing annotations for several configs. (#20871) (#20899)
  planner: add doc for `tidb_ignore_inlist_plan_digest`. (#20870) (#20890)
  JDBC URL: update the letter case for defaultFetchSize (#20884) (#20887)
  fix(pd): add missing configuration items for PD (#20883) (#20894)
  hardware-and-software-requirements: update Kylin Euler to Kylin (#20874) (#20881)
  add FAQs about collation for JDBC connections (#20848) (#20869)
  pd configuration: add dashboard.disable-custom-prom-addr (#20853) (#20857)
  releases: add one br entry to v8.1.2 (#20861) (#20864)
  toc: add TiDB release support policy (#19119) (#20859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants