-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rolling up PRs in the queue #17629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rolling up PRs in the queue #17629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om source This is more consistent with how the other channels work.
The for loop would *always* exaust the iterator previously, which seems like behavior that was not intended. It's still kind of a weird function.
in favor of `move`. This breaks code that used `move` as an identifier, because it is now a keyword. Change such identifiers to not use the keyword `move`. Additionally, this breaks code that was counting on by-value or by-reference capture semantics for unboxed closures (behind the feature gate). Change `ref |:|` to `|:|` and `|:|` to `move |:|`. Part of RFC rust-lang#63; part of issue rust-lang#12831. [breaking-change]
The syntax sugar is `[mut from..to]` not `[from..to]`
Modify the system %PATH% environment variable instead of the current user's %PATH% environment. The current user will be an admin user that may not be the same user who originally started the installer. Closes rust-lang#17570.
This makes it easier to experiment with improved quasiquoting as an ordinary plugin library. The list of quote macros in feature_gate.rs was already out of sync; this commit also prevents that problem in the future.
Also fix an existing compile-fail test which was intended to cover this case. This closes issue rust-lang#17593
This prevents ICEs or less helpful diagnostics if typeck proceeds further. Closes issue rust-lang#17441
- Removes f128 from the grammar, which is no longer support in rustc - The fragment modifier is added so it won't parse float suffix as a separate token
The reason that 'ar' can fail with permission denied is that when link-time optimizations are enabled, rustc copies libraries into a temporary directory, preserving file permissions, and subsequently modifies them using 'ar'. The modification can fail because some package managers may install libraries in system directories as read-only files, which means the temporary file also becomes read-only when it is copied. I have fixed this by giving the temporary file's owner read+write permissions after the copy. I have also added a regression test for this issue.
183ba16
to
d3e1718
Compare
bors
added a commit
that referenced
this pull request
Sep 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.