Skip to content

Test for .. in range patterns #17614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2014
Merged

Test for .. in range patterns #17614

merged 1 commit into from
Sep 29, 2014

Conversation

nrc
Copy link
Member

@nrc nrc commented Sep 28, 2014

@sinistersnare
Copy link
Contributor

Quick question, why isn't this allowed? it seems fairly nifty.

@alexcrichton
Copy link
Member

Currently the slicing syntax uses foo[a..b] where the range being used is inclusive of a and exclusive of b (doesn't include foo[b]). For match arms, the syntax 'a' .. 'z' (old syntax) is inclusive of both 'a' and 'z'. In order to resolve this issue, we're requiring that match arms use three dots instead of two (to highlight the difference).

Some have said a good way to think of this is "more dots equals more items"

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 29, 2014
@alexcrichton
rollup merge of rust-lang#17614 : nick29581/slice3
915511e
@bors bors merged commit 2c589df into rust-lang:master Sep 29, 2014
@alexcrichton
Copy link
Member

Ah oops, I landed the test, but I had to disable it because the error wasn't turned on yet, sorry about that!

@alexcrichton
Copy link
Member

And now github won't let me reopen this...

lnicola pushed a commit to lnicola/rust that referenced this pull request Jul 28, 2024
@bors
Auto merge of rust-lang#17614 - lnicola:build-scripts-override-docs, …
523465a 
…r=lnicola

minor: Add --keep-going to the `cargo.buildScripts.overrideCommand` docs

CC rust-lang/rust-analyzer#17608 (comment)
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Aug 1, 2024
@bors
Auto merge of rust-lang#17614 - lnicola:build-scripts-override-docs, …
65288bd 
…r=lnicola

minor: Add --keep-going to the `cargo.buildScripts.overrideCommand` docs

CC rust-lang/rust-analyzer#17608 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrc @sinistersnare @alexcrichton @bors