Skip to content

Json pretty encoder doesn't encode enums the same way as the normal encoder #17607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drasich opened this issue Sep 28, 2014 · 4 comments
Closed

Json pretty encoder doesn't encode enums the same way as the normal encoder #17607

drasich opened this issue Sep 28, 2014 · 4 comments

Comments

@drasich
Copy link

drasich commented Sep 28, 2014

Encoding an enum field with the pretty encoder results in an ExpectedError when decoding.

In emit_enum_variant of the pretty encoder,
"variants" and "fields" need to be added to behave the same way as the normal encoder.
@kmcallister
Copy link
Contributor

Do you have a simple test case?

@bkoropoff
Copy link
Contributor

Taking a look

bkoropoff added a commit to bkoropoff/rust that referenced this issue Sep 29, 2014
@bkoropoff
Use the same JSON schema for encoding enums in PrettyEncoder as in En…
ae3d42e 
…coder

Closes issue rust-lang#17607
@bkoropoff bkoropoff mentioned this issue Sep 29, 2014
Merged
@alexcrichton
Copy link
Member

Closed by #17623

@drasich
Copy link
Author

drasich commented Oct 1, 2014

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drasich @alexcrichton @kmcallister @bkoropoff