Lint files in exec folder on lint_package
#1950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX r-lib#1947 As per https://cran.r-project.org/doc/manuals/R-exts.html#Package-subdirectories: Subdirectory exec could contain additional executable scripts the package needs, typically scripts for interpreters such as the shell, Perl, or Tcl.
Codecov Report
@@ Coverage Diff @@
## main #1950 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 113 113
Lines 4991 4991
=======================================
Hits 4939 4939
Misses 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
|
LGTM. Please extend one of the test packages & write a test for this. Thanks! |
|
Tests added, @MichaelChirico. Ready for review |
|
Great! One last thing, please add a NEWS item & be sure to cite yourself. Thanks again! |
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #1947
As per https://cran.r-project.org/doc/manuals/R-exts.html#Package-subdirectories:
Subdirectory exec could contain additional executable scripts the package needs, typically scripts for interpreters such as the shell, Perl, or Tcl.