Lint files in exec folder on lint_package (#1950)

* Lint files in `exec` folder on lint_package

FIX #1947

As per https://cran.r-project.org/doc/manuals/R-exts.html#Package-subdirectories:

Subdirectory exec could contain additional executable scripts the package
needs, typically scripts for interpreters such as the shell, Perl, or Tcl.

* Add Oxford comma

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>

* Update .Rd

* Test for files in exec/

* Update NEWS [skip ci]

* Change file extensions .r -> .R

* Update file extension

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>

* Update NEWS.md

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>

---------

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>

Author: jmaspons

NEWS.md

@@ -70,6 +70,8 @@
    + `unnecessary_concatenation_linter()`
    + `whitespace_linter()`
 
+* `lint_package()` also looks for files in `exec/` (#1950, @jmaspons).
+
 ## New and improved features
 
 * New `get_r_string()` helper to get the R-equivalent value of a string, especially useful for R-4-style raw strings.
@@ -184,6 +186,7 @@
   Thanks to Yihui and other developers for their helpful discussions around this issue (#797, @IndrajeetPatil).
 
 * The output of `lint()` and `Lint()` gain S3 class `"list"` to assist with S3 dispatch (#1494, @MichaelChirico)
+
 # lintr 3.0.2
 
 * Fix test to avoid leaving behind cache files in the global cache directory.

R/lint.R

@@ -3,7 +3,7 @@
 #' * `lint()` lints a single file.
 #' * `lint_dir()` lints all files in a directory.
 #' * `lint_package()` lints all likely locations for R files in a package, i.e.
-#'   `R/`, `tests/`, `inst/`, `vignettes/`, `data-raw/`, and `demo/`.
+#'   `R/`, `tests/`, `inst/`, `vignettes/`, `data-raw/`, `demo/`, and `exec/`.
 #'
 #' Read `vignette("lintr")` to learn how to configure which linters are run
 #' by default.
@@ -262,7 +262,7 @@ lint_package <- function(path = ".", ...,
     root = pkg_path
   )
 
-  r_directories <- file.path(pkg_path, c("R", "tests", "inst", "vignettes", "data-raw", "demo"))
+  r_directories <- file.path(pkg_path, c("R", "tests", "inst", "vignettes", "data-raw", "demo", "exec"))
   # TODO: once relative_path= is fully deprecated as 2nd positional argument (see top of body), restore the cleaner:
   # > lints <- lint_dir(r_directories, relative_path = FALSE, exclusions = exclusions, parse_settings = FALSE, ...)
   lints <- do.call(

man/lint.Rd

@@ -0,0 +1,3 @@
+# lint errors should be included in test-lint_package.R
+x = 1:4
+res<- lapply(x, function(y) y+1)

tests/testthat/dummy_packages/assignmentLinter/exec/script.R

@@ -0,0 +1,3 @@
+# Each of the default linters should throw at least one lint for assignment_linter or object_name_linter on this file
+x = 1:4
+res <- lapply(x, function(y) y + 1)

tests/testthat/dummy_packages/package/exec/script.R

@@ -25,7 +25,9 @@ test_that(
       "abc = 123",
       # from jkl.R
       "jkl = 456",
-      "mno = 789"
+      "mno = 789",
+      # from exec/script.R
+      "x = 1:4"
     )
 
     lints_from_outside <- lint_package(
@@ -80,7 +82,7 @@ test_that(
     # `jkl.R` (and remove it on finishing this test)
     local_config(pkg_path, "exclusions: list('R/abc.R', 'R/jkl.R' = 1)")
 
-    expected_lines <- "mno = 789"
+    expected_lines <- c("mno = 789", "x = 1:4")
     lints_from_outside <- lint_package(
       pkg_path,
       linters = list(assignment_linter())