Skip to content

Commit 2d8a12d

Browse files
exclude deprecated linters from overall list & tag-specific lists (#1958)
1 parent 2b06c52 commit 2d8a12d

10 files changed

+58
-60
lines changed

R/linter_tags.R

+5-3
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ rd_tags <- function(linter_name) {
166166
#'
167167
#' @noRd
168168
rd_linters <- function(tag_name) {
169-
linters <- available_linters(tags = tag_name, exclude_tags = NULL)
169+
linters <- available_linters(tags = tag_name)
170170
tagged <- platform_independent_sort(linters[["linter"]])
171171
if (length(tagged) == 0L) {
172172
stop("No linters found associated with tag ", tag_name)
@@ -187,9 +187,11 @@ rd_linters <- function(tag_name) {
187187
#' @noRd
188188
rd_taglist <- function() {
189189
linters <- available_linters(exclude_tags = NULL)
190+
# don't count tags on deprecated linters to the counts of other tags
191+
linters$tags <- lapply(linters$tags, function(x) if ("deprecated" %in% x) "deprecated" else x)
190192

191193
tag_table <- table(unlist(linters[["tags"]]))
192-
tags <- platform_independent_sort(unique(unlist(linters[["tags"]])))
194+
tags <- platform_independent_sort(names(tag_table))
193195
# re-order
194196
tag_table <- tag_table[tags]
195197

@@ -209,7 +211,7 @@ rd_taglist <- function() {
209211
#'
210212
#' @noRd
211213
rd_linterlist <- function() {
212-
linters <- available_linters(exclude_tags = NULL)
214+
linters <- available_linters()
213215
linter_names <- platform_independent_sort(linters[["linter"]])
214216

215217
c(

man/available_linters.Rd

+6-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/configurable_linters.Rd

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/consistency_linters.Rd

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/efficiency_linters.Rd

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/linters.Rd

+5-13
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/linters_with_tags.Rd

+2-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/readability_linters.Rd

-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/style_linters.Rd

-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)