-
Notifications
You must be signed in to change notification settings - Fork 533
REL: 1.1.6 #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
REL: 1.1.6 #2800
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7485570
DOC: 1.1.6 Changelog
effigies abd805d
MNT: Version 1.1.6
effigies 0d0b05f
TEST: make specs
effigies 9f30f79
MAINT: Update zenodo ordering
effigies 47fad80
FIX: Numpy dependency
effigies 0076a89
CI: Test Numpy version under Python 3.7
effigies 955a18c
MAINT: Make numpy min version explicitly for Python > 3.7
effigies 838f95e
CI: Update Python 3.7 install test
effigies 7d69429
Merge remote-tracking branch 'upstream/master' into rel/1.1.6
effigies 9851fe4
DOC: Update changelog
effigies 1de9f69
MAINT: Remove pseudonym from zenodo
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
# full release. '.dev' as a version_extra string means this is a development | ||
# version | ||
# Remove -dev for release | ||
__version__ = '1.1.6-dev' | ||
__version__ = '1.1.6' | ||
|
||
|
||
def get_nipype_gitversion(): | ||
|
@@ -101,9 +101,10 @@ def get_nipype_gitversion(): | |
# versions | ||
NIBABEL_MIN_VERSION = '2.1.0' | ||
NETWORKX_MIN_VERSION = '1.9' | ||
NUMPY_MIN_VERSION = '1.9.0' | ||
# Numpy bug in python 3.7: | ||
# https://www.opensourceanswers.com/blog/you-shouldnt-use-python-37-for-data-science-right-now.html | ||
NUMPY_MIN_VERSION = '1.9.0' if sys.version_info < (3, 7) else '1.15.4' | ||
NUMPY_MIN_VERSION_37 = '1.15.3' | ||
SCIPY_MIN_VERSION = '0.14' | ||
TRAITS_MIN_VERSION = '4.6' | ||
DATEUTIL_MIN_VERSION = '2.2' | ||
|
@@ -135,7 +136,8 @@ def get_nipype_gitversion(): | |
REQUIRES = [ | ||
'nibabel>=%s' % NIBABEL_MIN_VERSION, | ||
'networkx>=%s' % NETWORKX_MIN_VERSION, | ||
'numpy>=%s' % NUMPY_MIN_VERSION, | ||
'numpy>=%s ; python_version < "3.7"' % NUMPY_MIN_VERSION, | ||
'numpy>=%s ; python_version >= "3.7"' % NUMPY_MIN_VERSION_37, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @satra @oesteban This is intended to address #2775 (comment). I've tested locally with pip installs of the |
||
'python-dateutil>=%s' % DATEUTIL_MIN_VERSION, | ||
'scipy>=%s' % SCIPY_MIN_VERSION, | ||
'traits>=%s' % TRAITS_MIN_VERSION, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From earlier comment, this appears to be a psuedonym. Let me know if I should restore it.