Skip to content

REL: 1.1.6 #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 26, 2018
12 changes: 11 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
_machine_kwds: &machine_kwds
image: circleci/classic:201710-02
image: circleci/classic:201808-01

_store_artifacts_kwds: &store_artifacts_kwds
path: /home/circleci/work/tests
Expand Down Expand Up @@ -356,6 +356,16 @@ jobs:
pip install dist/nipype-*-py2.py3-none-any.whl
# Futures should not install in Python 3
test $(pip show futures 2>/dev/null | wc -l) = "0"
- run:
name: Validate Python 3.7 installation
command: |
pyenv local 3.7.0
pip install --upgrade pip
# Pre-install a version of numpy that will not pass
pip install numpy==1.15.0
pip install dist/nipype-*-py2.py3-none-any.whl
# Numpy should be upgraded to >= 1.15.3
test "$(pip show numpy | grep Version)" \> "Version: 1.15.2"
- store_artifacts:
path: /home/circleci/nipype/dist

Expand Down
19 changes: 8 additions & 11 deletions .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,11 @@
{
"name": "Hallquist, Michael"
},
{
"affiliation": "GIGA Institute",
"name": "Grignard, Martin",
"orcid": "0000-0001-5549-1861"
},
{
"affiliation": "Donders Institute for Brain, Cognition and Behavior, Center for Cognitive Neuroimaging",
"name": "Chetverikov, Andrey",
Expand Down Expand Up @@ -451,12 +456,6 @@
"name": "Durnez, Joke",
"orcid": "0000-0001-9030-2202"
},
{
"name": "Mertz, Fred"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From earlier comment, this appears to be a psuedonym. Let me know if I should restore it.

{
"name": "Haehn, Daniel"
},
{
"affiliation": "Technische Universit\u00e4t Dresden, Faculty of Medicine, Department of Child and Adolescent Psychiatry",
"name": "Geisler, Daniel",
Expand All @@ -481,6 +480,9 @@
"name": "Molina-Romero, Miguel",
"orcid": "0000-0001-8054-0426"
},
{
"name": "Haehn, Daniel"
},
{
"name": "Weinstein, Alejandro"
},
Expand Down Expand Up @@ -587,11 +589,6 @@
"affiliation": "MIT, HMS",
"name": "Ghosh, Satrajit",
"orcid": "0000-0002-5312-6729"
},
{
"affiliation": "GIGA Institute",
"name": "Grignard, Martin",
"orcid": "0000-0001-5549-1861"
}
],
"keywords": [
Expand Down
21 changes: 21 additions & 0 deletions doc/changelog/1.X.X-changelog
Original file line number Diff line number Diff line change
@@ -1,3 +1,24 @@
1.1.6 (November 26, 2018)
=========================

##### [Full changelog](https://github.com/nipy/nipype/milestone/27?closed=1)

* [FIX] MapNodes fail when ``MultiProcPlugin`` passed by instance (https://github.com/nipy/nipype/pull/2786)
* [FIX] --fineTune arguments order for MeshFix command (https://github.com/nipy/nipype/pull/2780)
* [ENH] Add mp_context plugin arg for MultiProc (https://github.com/nipy/nipype/pull/2778)
* [ENH] Create a crashfile even if 'stop_on_first_crash' is set (https://github.com/nipy/nipype/pull/2774)
* [ENH] Add ExtractedBrainN4 output to ANTs CorticalThickness interface (https://github.com/nipy/nipype/pull/2784)
* [STY] Combine split import (https://github.com/nipy/nipype/pull/2801)
* [DOC] use https in css stylesheet url (https://github.com/nipy/nipype/pull/2779)
* [MAINT] Outsource ``get_filecopy_info()`` from interfaces (https://github.com/nipy/nipype/pull/2798)
* [MAINT] Import only Sequence to avoid DeprecationWarning (https://github.com/nipy/nipype/pull/2793)
* [MAINT] One less DeprecationWarning (configparser) (https://github.com/nipy/nipype/pull/2794)
* [MAINT] DeprecationWarning: use ``HasTraits.trait_set`` instead (https://github.com/nipy/nipype/pull/2792)
* [MAINT] Stop using deprecated ``logger.warn()`` (https://github.com/nipy/nipype/pull/2788)
* [MAINT] Move ``interfaces.base.run_command`` to ``nipype.utils.subprocess`` (https://github.com/nipy/nipype/pull/2777)
* [MAINT] Force numpy>=1.15.4 when Python>=3.7 (https://github.com/nipy/nipype/pull/2775)


1.1.5 (November 08, 2018)
=========================

Expand Down
8 changes: 5 additions & 3 deletions nipype/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# full release. '.dev' as a version_extra string means this is a development
# version
# Remove -dev for release
__version__ = '1.1.6-dev'
__version__ = '1.1.6'


def get_nipype_gitversion():
Expand Down Expand Up @@ -101,9 +101,10 @@ def get_nipype_gitversion():
# versions
NIBABEL_MIN_VERSION = '2.1.0'
NETWORKX_MIN_VERSION = '1.9'
NUMPY_MIN_VERSION = '1.9.0'
# Numpy bug in python 3.7:
# https://www.opensourceanswers.com/blog/you-shouldnt-use-python-37-for-data-science-right-now.html
NUMPY_MIN_VERSION = '1.9.0' if sys.version_info < (3, 7) else '1.15.4'
NUMPY_MIN_VERSION_37 = '1.15.3'
SCIPY_MIN_VERSION = '0.14'
TRAITS_MIN_VERSION = '4.6'
DATEUTIL_MIN_VERSION = '2.2'
Expand Down Expand Up @@ -135,7 +136,8 @@ def get_nipype_gitversion():
REQUIRES = [
'nibabel>=%s' % NIBABEL_MIN_VERSION,
'networkx>=%s' % NETWORKX_MIN_VERSION,
'numpy>=%s' % NUMPY_MIN_VERSION,
'numpy>=%s ; python_version < "3.7"' % NUMPY_MIN_VERSION,
'numpy>=%s ; python_version >= "3.7"' % NUMPY_MIN_VERSION_37,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satra @oesteban This is intended to address #2775 (comment). I've tested locally with pip installs of the bdist wheel in different conda environments. Added a test to CI, so we'll see how that goes.

'python-dateutil>=%s' % DATEUTIL_MIN_VERSION,
'scipy>=%s' % SCIPY_MIN_VERSION,
'traits>=%s' % TRAITS_MIN_VERSION,
Expand Down
6 changes: 4 additions & 2 deletions nipype/interfaces/tests/test_auto_MeshFix.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,23 @@ def test_MeshFix_inputs():
epsilon_angle=dict(argstr='-a %f', ),
finetuning_distance=dict(
argstr='%f',
position=-2,
requires=['finetuning_substeps'],
),
finetuning_inwards=dict(
argstr='--fineTuneIn ',
position=-3,
requires=['finetuning_distance', 'finetuning_substeps'],
),
finetuning_outwards=dict(
argstr='--fineTuneOut ',
position=-3,
requires=['finetuning_distance', 'finetuning_substeps'],
xor=['finetuning_inwards'],
),
finetuning_substeps=dict(
argstr='%d',
position=-1,
requires=['finetuning_distance'],
),
in_file1=dict(
Expand Down Expand Up @@ -89,8 +93,6 @@ def test_MeshFix_inputs():
for key, metadata in list(input_map.items()):
for metakey, value in list(metadata.items()):
assert getattr(inputs.traits()[key], metakey) == value


def test_MeshFix_outputs():
output_map = dict(mesh_file=dict(), )
outputs = MeshFix.output_spec()
Expand Down