Skip to content

[PIN] Force numpy>=1.15.4 when Python>=3.7 #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

oesteban
Copy link
Contributor

Addresses the numpy
bug
.

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #2775 into master will decrease coverage by 2.9%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2775      +/-   ##
=========================================
- Coverage      67%   64.1%   -2.91%     
=========================================
  Files         340     338       -2     
  Lines       43271   43220      -51     
  Branches     5364    5361       -3     
=========================================
- Hits        28995   27705    -1290     
- Misses      13548   14446     +898     
- Partials      728    1069     +341
Flag Coverage Δ
#smoketests ?
#unittests 64.1% <100%> (-0.24%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 88.05% <100%> (+2.98%) ⬆️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/algorithms/rapidart.py 35.39% <0%> (-29.21%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.99%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-28.36%) ⬇️
nipype/interfaces/spm/base.py 58.41% <0%> (-25.75%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.17%) ⬇️
nipype/interfaces/freesurfer/base.py 49.59% <0%> (-23.58%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 911601b...b8227e7. Read the comment docs.

@satra satra merged commit e475331 into nipy:master Nov 13, 2018
@satra
Copy link
Member

satra commented Nov 13, 2018

@mgxd - just a note that we should adjust the conda feedstock for this as well.

@oesteban oesteban deleted the pin/numpy-1.15.4-python-3.7 branch November 13, 2018 04:25
@effigies
Copy link
Member

I think this will work for sdist, but not bdist. To encode this requirement in the actual package metadata, I think we'll need to use PEP 508 syntax. e.g.

numpy >= 1.9.1
numpy >= 1.15.3 ; python_version >= "3.7"

(That may not work.)

@satra Conda doesn't seem to work well with 3.7 yet. There's an open PR (conda-forge/nipype-feedstock#28) that tries to update to support 3.7 that hasn't yet passed tests.

@effigies effigies mentioned this pull request Nov 26, 2018
7 tasks
@effigies effigies added this to the 1.1.6 milestone Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants