Skip to content

REL: 1.1.6 #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 26, 2018
Merged

REL: 1.1.6 #2800

merged 11 commits into from
Nov 26, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented Nov 26, 2018

Summary

Prep for 1.1.6 release, targeting Monday, November 26.

Release checklist

  • Update changelog
  • Update .mailmap
  • Update .zenodo.json
  • Set release number in nipype/info.py and doc/conf.py
  • Update doc/documentation.rst with previous releases
  • Tutorial tests (@djarecka)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8a813fe). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2800   +/-   ##
=========================================
  Coverage          ?   64.07%           
=========================================
  Files             ?      339           
  Lines             ?    43245           
  Branches          ?     5366           
=========================================
  Hits              ?    27709           
  Misses            ?    14465           
  Partials          ?     1071
Flag Coverage Δ
#unittests 64.07% <100%> (?)
Impacted Files Coverage Δ
nipype/info.py 85.29% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a813fe...1de9f69. Read the comment docs.

.zenodo.json Outdated
@@ -454,9 +459,6 @@
{
"name": "Mertz, Fred"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fred Mertz is almost certainly a pseudonym that got sweeped up in an earlier mass addition to .zenodo.json. I think it should probably be removed. @satra?

@@ -136,6 +137,7 @@ def get_nipype_gitversion():
'nibabel>=%s' % NIBABEL_MIN_VERSION,
'networkx>=%s' % NETWORKX_MIN_VERSION,
'numpy>=%s' % NUMPY_MIN_VERSION,
'numpy>=%s ; python_version >= "3.7"' % NUMPY_MIN_VERSION_37,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satra @oesteban This is intended to address #2775 (comment). I've tested locally with pip installs of the bdist wheel in different conda environments. Added a test to CI, so we'll see how that goes.

@oesteban oesteban mentioned this pull request Nov 26, 2018
1 task
@@ -451,12 +456,6 @@
"name": "Durnez, Joke",
"orcid": "0000-0001-9030-2202"
},
{
"name": "Mertz, Fred"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From earlier comment, this appears to be a psuedonym. Let me know if I should restore it.

@effigies
Copy link
Member Author

@djarecka This is in final state, as far as I'm concerned. If you haven't already, could you start the tutorial tests?

@effigies effigies added this to the 1.1.6 milestone Nov 26, 2018
@djarecka
Copy link
Collaborator

@effigies - I checked the version from 2 hours ago, don't think you've changed anything since then that can affect the tutorial

@effigies
Copy link
Member Author

@djarecka Sounds good. Thanks.

@nipy/team-nipype Will merge and release on passing tests unless anyone objects.

@effigies effigies merged commit b448b60 into master Nov 26, 2018
@effigies effigies deleted the rel/1.1.6 branch November 26, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants