-
Notifications
You must be signed in to change notification settings - Fork 533
REL: 1.1.6 #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: 1.1.6 #2800
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2800 +/- ##
=========================================
Coverage ? 64.07%
=========================================
Files ? 339
Lines ? 43245
Branches ? 5366
=========================================
Hits ? 27709
Misses ? 14465
Partials ? 1071
Continue to review full report at Codecov.
|
.zenodo.json
Outdated
@@ -454,9 +459,6 @@ | |||
{ | |||
"name": "Mertz, Fred" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fred Mertz is almost certainly a pseudonym that got sweeped up in an earlier mass addition to .zenodo.json
. I think it should probably be removed. @satra?
@@ -136,6 +137,7 @@ def get_nipype_gitversion(): | |||
'nibabel>=%s' % NIBABEL_MIN_VERSION, | |||
'networkx>=%s' % NETWORKX_MIN_VERSION, | |||
'numpy>=%s' % NUMPY_MIN_VERSION, | |||
'numpy>=%s ; python_version >= "3.7"' % NUMPY_MIN_VERSION_37, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satra @oesteban This is intended to address #2775 (comment). I've tested locally with pip installs of the bdist
wheel in different conda environments. Added a test to CI, so we'll see how that goes.
@@ -451,12 +456,6 @@ | |||
"name": "Durnez, Joke", | |||
"orcid": "0000-0001-9030-2202" | |||
}, | |||
{ | |||
"name": "Mertz, Fred" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From earlier comment, this appears to be a psuedonym. Let me know if I should restore it.
@djarecka This is in final state, as far as I'm concerned. If you haven't already, could you start the tutorial tests? |
@effigies - I checked the version from 2 hours ago, don't think you've changed anything since then that can affect the tutorial |
@djarecka Sounds good. Thanks. @nipy/team-nipype Will merge and release on passing tests unless anyone objects. |
Summary
Prep for 1.1.6 release, targeting Monday, November 26.
Release checklist
nipype/info.py
anddoc/conf.py
doc/documentation.rst
with previous releasesAcknowledgment