Skip to content

Added Attributes.asdict #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

Added Attributes.asdict #2221

merged 1 commit into from
Sep 24, 2024

Conversation

TomAugspurger
Copy link
Contributor

Restores Attributes.asdict, for zarr v2 compatibility.

xref #2214, which has some open questions about Group.attrs vs. AsyncGroup.attrs.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@TomAugspurger TomAugspurger mentioned this pull request Sep 23, 2024
Closed
4 tasks
@jhamman
Copy link
Member

jhamman commented Sep 24, 2024

xref #2214, which has some open questions about Group.attrs vs. AsyncGroup.attrs.

I left some comments there on this topic.

@jhamman jhamman merged commit 2a78497 into zarr-developers:v3 Sep 24, 2024
26 checks passed
@TomAugspurger TomAugspurger deleted the fix/attrs-asdict branch September 24, 2024 11:47
dcherian added a commit to dcherian/zarr-python that referenced this pull request Sep 27, 2024
@dcherian
Merge branch 'v3' into generalize-stateful-store
80a83a1 
* v3:
  remove outdated v2 source code and tests from v3 branch (zarr-developers#2182)
  Fix/empty listdir (zarr-developers#2225)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#2219)
  Added Attributes.asdict (zarr-developers#2221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAugspurger @jhamman