You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's an inconsistency between Group.attrs and AsyncGroup.attrs. Group.attrs returns an Attributes object while AsyncGroup.attrs returns an Attributes object. Just wanted to confirm that this is deliberate.
I'm planning to add an asdict() method to Attributes for v2 compatibility.
Steps to reproduce
In [13]: g=zarr.open_group(store={}, mode="w")
In [14]: g.attrsOut[14]: <zarr.core.attributes.Attributesat0x10bd902e0>In [15]: g._async_group.attrsOut[15]: {}
Additional output
No response
The text was updated successfully, but these errors were encountered:
Good catch @TomAugspurger. I had forgotten to come back to this.
The dict-like attrs property on the sync Array is not really possible for the AsyncArray. My conclusion is that we probably need something like an AsyncAttributes class:
Zarr version
v3
Numcodecs version
na
Python Version
na
Operating System
na
Installation
na
Description
There's an inconsistency between
Group.attrs
andAsyncGroup.attrs
. Group.attrs returns anAttributes
object whileAsyncGroup.attrs
returns anAttributes
object. Just wanted to confirm that this is deliberate.I'm planning to add an
asdict()
method toAttributes
for v2 compatibility.Steps to reproduce
Additional output
No response
The text was updated successfully, but these errors were encountered: