-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
fix(runtime-core): stop tracking deps in setRef during unmount #13210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
It doesn't seem to have fixed it. Playground with this PR |
Updated. Could you please confirm this again? |
@makedopamine Nice. It's fixed. |
Can we have tests for this? I see this easily being reintroduced if this code ever gets refactored. |
Agreed! Could you contribute a test case if you'd like? |
The tests need to be implemented as E2E because the leak is in the detached DOM nodes, which were not possible to reproduce in Vitest regardless of the presence of JSDOM or not to mock the DOM (in runtime/core tests we test VNodes, not real DOM elements)
fix #13209