Skip to content

[Tracing] Reinstate ignore functionality #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

[Tracing] Reinstate ignore functionality #1423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3706450
add back ignore for now
kylesayrs May 12, 2025
1a2076a
Merge branch 'main' into kylesayrs/tracing-ignore
kylesayrs May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/llmcompressor/pipelines/sequential/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,16 @@ def trace_subgraphs(
:param sample_input: inputs whose values will change during execution but whose
__len__, __bool__, and __contains__ values are assumed constant across batches
:param sequential_targets: list of patterns matching sequential targets
:param ignore: TODO: unused, in the future will specify functions and methods to
skip during tracing
:param ignore: modules to ignore during tracing, in the future will specify
functions and methods to skip during tracing
:return: a list of Subgraphs in order of execution
"""
# find modules
sequential_targets = match_modules(model, sequential_targets)
ignore = match_modules(model, ignore)

# initialize arguments
tracer = get_tracer(model, sequential_targets)
tracer = get_tracer(model, sequential_targets, ignore)
concrete_args = populate_concrete_args(model, sample_input)

# trace
Expand Down Expand Up @@ -118,7 +119,9 @@ def trace_subgraphs(
return subgraphs


def get_tracer(model: Module, sequential_targets: Set[Module]) -> HFTracer:
def get_tracer(
model: Module, sequential_targets: Set[Module], ignore: Set[Module]
) -> HFTracer:
"""
Get a tracer specialized for the given model. The resulting tracer will not trace
inside of sequential targets, nor any modules which are not call graph ancestors of
Expand All @@ -129,6 +132,8 @@ def get_tracer(model: Module, sequential_targets: Set[Module]) -> HFTracer:

:param model: model being traced
:param sequential_targets: modules which are sequential targets
:param ignore: modules to ignore during tracing, in the future will specify
functions and methods to skip during tracing
"""
sequential_ancestors = get_sequential_ancestors(model, sequential_targets)
offloaded_modules = set(m for m in model.modules() if has_offloaded_params(m))
Expand All @@ -155,7 +160,11 @@ def create_arg(self, a: Any) -> Argument:
return super().create_arg(a)

def is_leaf_module(self, module: Module, module_qualified_name: str) -> bool:
return module not in sequential_ancestors or module in offloaded_modules
return (
module not in sequential_ancestors
or module in offloaded_modules
or module in ignore
)

def trace(self, root: Union[Module, Callable], *args, **kwargs) -> Graph:
if isinstance(root, Module):
Expand Down