Skip to content

[Tracing] Reinstate ignore functionality #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented May 12, 2025

Purpose

  • Fix issues with e2e testing and examples where some recipe still target vision decoder blocks in the no_split_params, and therefore trace the vision sections

Changes

  • Add back module ignoring functionality

Testing

  • Ran qwen2_5_vl example and demonstrated that tracing that works nows with default no_split_params

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs marked this pull request as ready for review May 12, 2025 14:28
@kylesayrs kylesayrs added the ready When a PR is ready for review label May 12, 2025
@kylesayrs kylesayrs enabled auto-merge (squash) May 12, 2025 15:00
@kylesayrs kylesayrs merged commit 802e869 into main May 12, 2025
11 checks passed
@kylesayrs kylesayrs deleted the kylesayrs/tracing-ignore branch May 12, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants