[BUGFIX] Removes the class properties transform for the latest ember-cli-babel

[pzuraq]

The latest ember-cli-babel supports class fields, so there's no reason to add the plugin here 🎉 and adding it breaks things ☹️

---

Edit by @chriskrycho, 2019/04/26: For searchability, adding the text of the kind of error users see without this:

WARNING: my-app has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.

[chriskrycho]

Looks good, but we actually have a test covering this, which is currently failing! Do you mind digging in and making sure we get the right behavior?

[dfreeman]

I'm guessing this domain won't resolve from the outside world?

[pzuraq]

ah lol, I guess something got messed up with my config

[josemarluedke]

I can confirm that there are issues with the current version of ember-cli-typescript (v2) when using ember-cli-babel v7.7.

Hopefully this fixes these.

[chriskrycho]

@pzuraq would you be so kind as to rebase this and one of us will merge it tomorrow? Thanks again!

[mike-north]

We currently have "ember-cli-babel@7.7.3" on master, and no sign of test failure in any environment.

If we can get some steps to reproduce the problem this PR fixes, I'd be happy to implement equivalent tests.

[pzuraq]

Master likely still causes warnings to pop up, so this PR should be updated to not add the class fields plugin and prevent those warnings. Will do it momentarily

[mike-north]

Master likely still causes warnings to pop up, so this PR should be updated to not add the class fields plugin and prevent those warnings. Will do it momentarily

We have tests that assert on terminal output, so it should be possible to write one for this

[chriskrycho]

@pzuraq mind updating this with the suggested tests (one of us can point you where you need for reference if need be) and a fresh rebase?

[pzuraq]

Yeah, I'm just a bit overloaded at the moment, so unsure when I'll be able to get to updating/adding tests. I can definitely rebase though.

[chriskrycho]

Totally understand – thank you!

[chriskrycho]

Got the warning message today, so now I have a better idea of what we're dealing with here

WARNING: @snap-doc/app has added the decorators plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms. Ember supports the stage 1 decorator spec and transforms, so if you were using stage 2, you'll need to ensure that your decorators are compatible, or convert them to stage 1.

WARNING: @snap-doc/app has added the class-properties plugin to its build, but ember-cli-babel provides these by default now! You can remove the transforms, or the addon that provided them, such as @ember-decorators/babel-transforms.

Originally posted by @mike-north in #623 (comment)

[rwjblue]

Where are we at on this?

[chriskrycho]

@rwjblue apparently @pzuraq has been buried in other things, and I've been neck-deep in work on Notion, so haven't touched it. I'm blocking out some time to clean up this and a few other things on Monday, though.

[jamescdavis]

Closing in favor of #730