Skip to content

CMP0157 is breaking the Windows nightlies #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
compnerd opened this issue Mar 21, 2025 · 2 comments
Open

CMP0157 is breaking the Windows nightlies #1222

compnerd opened this issue Mar 21, 2025 · 2 comments

Comments

@compnerd
Copy link
Member

https://ci-external.swift.org/job/swift-6.1-windows-toolchain/157/consoleText

This is caused by the lack of the early swift-driver on Windows. We need to disable CMP0157.

CC: @etcwilde @shahmishal
@Steelskin
Copy link

I believe this needs a CP of swiftlang/swift-corelibs-foundation#5180 into the release/6.1 branch. I'll get to it.

Steelskin added a commit to Steelskin/swift-corelibs-foundation that referenced this issue Mar 24, 2025
@Steelskin
Set CMP0157 to OLD only for Windows hosts
47e9467 
  - **Explanation**:
    There is no early swift-driver build for the Windows toolchain. As
    a result, swift-collections fails to build properly when CMP0157
    is set to NEW due to object files not being generated.

    This sets CMP0157 to OLD when targetting Android until the early
    swift-driver is available on Windows.
  - **Scope**:
    The changes are limited to the Android build on Windows.
  - **Issues**:
    - swiftlang/swift-foundation#1222
  - **Original PRs**:
    swiftlang#5180
  - **Risk**:
    Very low.
  - **Testing**:
    Fixes the Swift CI 6.1 build.
  - **Reviewers**:
    @finagolfin
@Steelskin Steelskin mentioned this issue Mar 24, 2025
Merged
parkera pushed a commit to swiftlang/swift-corelibs-foundation that referenced this issue Mar 25, 2025
@Steelskin
Set CMP0157 to OLD only for Windows hosts (#5195)
056b77b 
- **Explanation**:
    There is no early swift-driver build for the Windows toolchain. As
    a result, swift-collections fails to build properly when CMP0157
    is set to NEW due to object files not being generated.

    This sets CMP0157 to OLD when targetting Android until the early
    swift-driver is available on Windows.
  - **Scope**:
    The changes are limited to the Android build on Windows.
  - **Issues**:
    - swiftlang/swift-foundation#1222
  - **Original PRs**:
    #5180
  - **Risk**:
    Very low.
  - **Testing**:
    Fixes the Swift CI 6.1 build.
  - **Reviewers**:
    @finagolfin
@Steelskin
Copy link

Steelskin commented Mar 26, 2025 •
edited
Loading

This seems to be fixed but the 6.1 toolchain build is failing on something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@compnerd @Steelskin