Set CMP0157 to OLD only for Windows hosts #5195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Explanation**:
There is no early swift-driver build for the Windows toolchain. As
a result, swift-collections fails to build properly when CMP0157
is set to NEW due to object files not being generated.
This sets CMP0157 to OLD when targetting Android until the early
swift-driver is available on Windows.
- **Scope**:
The changes are limited to the Android build on Windows.
- **Issues**:
- swiftlang/swift-foundation#1222
- **Original PRs**:
swiftlang#5180
- **Risk**:
Very low.
- **Testing**:
Fixes the Swift CI 6.1 build.
- **Reviewers**:
@finagolfin
|
@swift-ci please test |
parkera
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
There is no early swift-driver build for the Windows toolchain. As a result, swift-collections fails to build properly when CMP0157 is set to NEW due to object files not being generated.
This sets CMP0157 to OLD when targetting Android until the early swift-driver is available on Windows.
Scope:
The changes are limited to the Android build on Windows.
Issues:
CMP0157 is breaking the Windows nightlies swift-foundation#1222
Original PRs:
Set CMP0157 to OLD for Android #5180
Risk:
Very low.
Testing:
Fixes the Swift CI 6.1 build.
Reviewers:
@finagolfin