Skip to content

Make python snippets able to handle arguments with type annotations. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

galaunay
Copy link

@galaunay galaunay commented Apr 23, 2018

As promised.
(Following discussion in elpy #1343)

I made a some tests, the four snippets concerned by the modifications ('_new', '_init', 'class' and 'super') seem to work fine.

I had to an additional quick fix (line 59) for the 'super' snippet to work.

wynro and others added 15 commits March 24, 2018 18:24
* Add bibtex-mode snippets

* Move yas-indent-line option to .yas-setup.el file
Thanks to galaunay for the idea to use this to "avoid unnecessary
keyspace pollution."
* fix indent function

* remove extra line
* bazel mode snippets for cc

* bazel mode snippets for java.

added bazel mode java snippets and added newline at eof

* bazel mode snippets for python

* bazel mode snippets for shell
* Add sum snippet for LaTeX

* Add int snippet for LaTeX

* Add prod snippet for LaTeX

* Add binom snippet for LaTeX

* Add bigcup snippet for LaTeX

* Add bigcap snippet for LaTeX

* Remove trailing lines

* Replace two-word arguments with one word

* Actually, remove the words entirely
* Add various snippets for org-mode

* Remove readme and sourcecode and fix typos

* Remove reveal_all and edit table snippet
Thanks to @AndreaCrotti for the review and suggestion.
The dollar sign was missing which caused a badly generated setter
method.
Fix the case of the getter and setter templates. The previous
method "capitalize" turned upper case characters to lower case
elsewhere in the string.
* Rename files that are prohibited in Debian packages

* Add missing keys for all markdown-mode snippets

* markdown-mode: Give a couple snippets more meaningful names

* markdown-mode/uft8: Modify description to say UTF-8

* Add MELPA stable badge.

@AndreaCrotti is now tagging stable releases, so I believe it is
appropriate to close AndreaCrotti#242
@sten0
Copy link
Owner

sten0 commented Apr 24, 2018

Concerning af1347d: Oh my, yas-snips-rpc-python-command was sloppy of me! Thank you so much for catching it, frankly I'm embarrassed to have missed this issue. Do you mind if I delay a day or two to do a bit of research/learning for a proposal I'd like to add a commit on top of af1347d, and do you mind if I commit to your fork? For what I've read it's permitted by default on github, but it's always polite to ask first, you know :-)

@galaunay
Copy link
Author

That's why some tests would be nice :).

Sure, commit where it is the more convenient for you.

@galaunay galaunay force-pushed the Improve-arg-for-python branch from e7b3f79 to 46d6424 Compare May 8, 2018 12:06
@galaunay
Copy link
Author

I assume that this can be closed.
Please re-open if it is not the case

@galaunay galaunay closed this Jan 30, 2019
@sten0
Copy link
Owner

sten0 commented Feb 6, 2019

Oh, yes, probably, because your commits are present (rebased/squashed as discussed) on AndreaCrotti#278. @AndreaCrotti is going to move forward with merging the non-conflicting no elisp dependency snippets, and later it looks like we'll have a round three of merging the problematic ones. I'm starting to suspect it might be faster/easier to just rewrite them with equivalent functionality :-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants