Support typescript-mode #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #139. For more details, see <https://github.com/ananthakumaran/typescript.el>.
|
Hi @ybiquitous thanks for your contribution, but just to clarify, doesn't it just mean that all the JS snippets will be available to typescript mode with this change? |
|
Hi. @AndreaCrotti However, since TypeScript is a superset of JavaScript, all JavaScript snippets can also be used in TypeScript. I wanted to use the TypeScript snippet with minimal effort first, so I just simply inherit JavaScript snippets in this PR. |
|
Yes sure fine, makes sense 👍 |
|
Thank you for understanding! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #139.
For more details, see https://github.com/ananthakumaran/typescript.el.