Skip to content

Enables empty authorityPrefix in JwtGrantedAuthoritiesConverter #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Enables empty authorityPrefix in JwtGrantedAuthoritiesConverter #8424

merged 1 commit into from
Apr 22, 2020

Conversation

judomu
Copy link
Contributor

@judomu judomu commented Apr 21, 2020

  • docs stated that empty authorityPrefix are allowed but implementation denied to use ""
  • commit removes the hasText-limitation but restricts to notNull

Fixes gh-8421

@judomu
Enables empty authorityPrefix
41f62f3 
- docs stated that empty authorityPrefix are allowed but implementation denied to use `""`
- commit removes the `hasText`-limitation but restricts to `notNull`

Fixes spring-projectsgh-8421
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 21, 2020
@rwinch rwinch changed the title Enables empty authorityPrefix Enables empty authorityPrefix in JwtGrantedAuthoritisConverter Apr 22, 2020
@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Apr 22, 2020
@rwinch rwinch self-assigned this Apr 22, 2020
@rwinch rwinch added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Apr 22, 2020
@rwinch rwinch added this to the 5.4.0.M1 milestone Apr 22, 2020
@rwinch rwinch added type: bug A general bug and removed type: enhancement A general enhancement labels Apr 22, 2020
@rwinch rwinch removed this from the 5.4.0.M1 milestone Apr 22, 2020
@rwinch rwinch added the status: duplicate A duplicate of another issue label Apr 22, 2020
@rwinch rwinch merged commit 60d4d5b into spring-projects:master Apr 22, 2020
@rwinch
Copy link
Member

rwinch commented Apr 22, 2020

Thanks for the Pull Request! This is now merged into master 😄

@rwinch rwinch changed the title Enables empty authorityPrefix in JwtGrantedAuthoritisConverter Enables empty authorityPrefix in JwtGrantedAuthoritiesConverter Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth2 Resource Server docs not in sync - authorityPrefix can't be set to ""
3 participants
@judomu @rwinch @spring-projects-issues