-
Notifications
You must be signed in to change notification settings - Fork 6k
OAuth2 Resource Server docs not in sync - authorityPrefix can't be set to "" #8421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
in: oauth2
An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
Comments
Thanks for the report. I think it is the implementation that is broken. Would you like to submit a PR to fix it? |
Sure, I will provide the fix |
Thanks @judomu! The issue is yours |
judomu
added a commit
to judomu/spring-security
that referenced
this issue
Apr 21, 2020
- docs stated that empty authorityPrefix are allowed but implementation denied to use `""` - commit removes the `hasText`-limitation but restricts to `notNull` Fixes spring-projectsgh-8421
rwinch
pushed a commit
that referenced
this issue
Apr 22, 2020
- docs stated that empty authorityPrefix are allowed but implementation denied to use `""` - commit removes the `hasText`-limitation but restricts to `notNull` Fixes gh-8421
rwinch
pushed a commit
that referenced
this issue
Apr 22, 2020
- docs stated that empty authorityPrefix are allowed but implementation denied to use `""` - commit removes the `hasText`-limitation but restricts to `notNull` Fixes gh-8421
This is now merged into master and 5.2.x |
eleftherias
pushed a commit
that referenced
this issue
Jul 7, 2020
- docs stated that empty authorityPrefix are allowed but implementation denied to use `""` - commit removes the `hasText`-limitation but restricts to `notNull` Fixes gh-8421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: oauth2
An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
In spring-security documentation (https://docs.spring.io/spring-security/site/docs/current/reference/html5/):
But that will not work
So the documentation is wrong or the implementation, imho the option to set authorityPrefix to "" makes sense to me.
The text was updated successfully, but these errors were encountered: