Skip to content

Adopt to AOT changes in Commons #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.0.x
Choose a base branch
from
Open

Adopt to AOT changes in Commons #4964

wants to merge 2 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented May 7, 2025

@mp911de mp911de requested a review from christophstrobl May 7, 2025 14:14
@mp911de mp911de added the type: enhancement A general enhancement label May 7, 2025
Copy link

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me. I will adapt what I have done in Spring Data Cassandra to fit this as well. I have a couple of comments but other than that LGTM.

@christophstrobl
Copy link
Member

christophstrobl commented May 8, 2025

The interface resolution when generating the <repo>.json file seems to be a little off for a repo interface that uses methods delegating to the default repository implementation when not using one of the predefined repository interfaces.

interface OwnerRepository extends Repository<Owner, Long> {
  void save(Owner owner);
}
{
  "name": "save",
  "signature": "public abstract void org.springframework.samples.petclinic.owner.OwnerRepository.save(org.springframework.samples.petclinic.owner.Owner)",
  "fragment": {
    "interface": "org.springframework.data.mongodb.repository.support.SimpleMongoRepository",
    "fragment": "org.springframework.data.mongodb.repository.support.SimpleMongoRepository"
  }
},

@mp911de
Copy link
Member Author

mp911de commented May 8, 2025

Yeah, I have no good idea to fix that yet. The interface in fragments refers to the type that contributes signatures when looking up methods. For Querydsl and fragments, that is the actual interface. Maybe we just suppress interface if the fragment is the same as interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants