Refine Repository Composition retrieval during AOT. #3282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add module identifier and base repository implementation properties. Fix fragment function previously overriding already set property due to name clash. Extend tests for bean definition resolution and code block creation.
Ignore warnings for already checked constructs null away does not understand.
mp911de
reviewed
May 6, 2025
| @@ -95,6 +95,10 @@ public abstract class RepositoryFactoryBeanSupport<T extends Repository<S, ID>, | |||
| private @Nullable Lazy<T> repository; | |||
| private @Nullable RepositoryMetadata repositoryMetadata; | |||
|
|
|||
| // AOT bean factory hint? | |||
| private @Nullable String moduleBaseClass; | |||
There was a problem hiding this comment.
Let's update @Enable…Repositories annotations in the modules supporting AOT repositories to declare the actual baseclass. Any objections?
Associate Repository Bean Definition with RepositoryConfiguration and RepositoryConfigurationExtension attributes to capture configuration details such as the module name or the configuration source. Introduce RepositoryFragmentsContributor to provide an abstraction for structural fragment implementation allowing to describe the implementation type instead of requiring the implementation object. Obtain repository fragments from a RepositoryFragmentsContributor (either the configured one or one from a RepositoryFactoryBean).
Introduce dedicated contributor interfaces to AotRepositoryBuilder.
christophstrobl
added a commit
that referenced
this pull request
May 8, 2025
Ignore warnings for already checked constructs null away does not understand. Original Pull Request: #3282
christophstrobl
pushed a commit
that referenced
this pull request
May 8, 2025
Associate Repository Bean Definition with RepositoryConfiguration and RepositoryConfigurationExtension attributes to capture configuration details such as the module name or the configuration source. Introduce RepositoryFragmentsContributor to provide an abstraction for structural fragment implementation allowing to describe the implementation type instead of requiring the implementation object. Obtain repository fragments from a RepositoryFragmentsContributor (either the configured one or one from a RepositoryFactoryBean). Closes: #3279 Original Pull Request: #3282
christophstrobl
pushed a commit
that referenced
this pull request
May 8, 2025
Original Pull Request: #3282
christophstrobl
added a commit
that referenced
this pull request
May 8, 2025
Fix nullability warnings and update copyright header. Original Pull Request: #3282
|
Merged to 4.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add module identifier and base repository implementation properties (seeks better alternative, maybe).
Fix fragment function previously overriding already set property due to name clash.
Extend tests for bean definition resolution and code block creation.