Skip to content

Add test for #15919 #24987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add test for #15919 #24987

wants to merge 2 commits into from

Conversation

bombless
Copy link
Contributor

Closes #15919

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member

@bors r+ b60c3e2 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request May 1, 2015
@Manishearth
Rollup merge of rust-lang#24987 - bombless:large-array, r=pnkfelix
fe54be2 
Closes rust-lang#15919
@Manishearth Manishearth mentioned this pull request May 1, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 1, 2015
@Manishearth
Fixup rust-lang#24987
ac12fc8
@Manishearth
Copy link
Member

@bors: r-

The test fails due to an unexpected warning. Manishearth@ac12fc8 fixes that, but the error disappears. Please fix these first, thanks!

bors added a commit that referenced this pull request May 1, 2015
@bors
Auto merge of #25025 - Manishearth:rollup, r=Manishearth
1320c29 
- Successful merges: #24979, #24980, #24981, #24982, #24983, #24987, #24988, #24991, #24992, #24994, #24998, #25002, #25010, #25014, #25020, #25021
- Failed merges:
@bombless
Copy link
Contributor Author

bombless commented May 1, 2015

Sorry, I'll reopen it once I fix it.

@bombless bombless closed this May 1, 2015
@bombless
Copy link
Contributor Author

bombless commented May 1, 2015

Okay, fixed. Sorry for the trouble.
r? @pnkfelix

@bombless bombless reopened this May 1, 2015
@bombless
Copy link
Contributor Author

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned brson May 12, 2015
@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 12, 2015

📌 Commit 4c8b813 has been approved by pnkfelix

@pnkfelix
Copy link
Member

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 12, 2015
@steveklabnik
Rollup merge of rust-lang#24987 - bombless:large-array, r=pnkfelix
6987900 
Closes rust-lang#15919
@steveklabnik steveklabnik mentioned this pull request May 12, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 13, 2015
@steveklabnik
Rollup merge of rust-lang#24987 - bombless:large-array, r=pnkfelix
d3dd694 
Closes rust-lang#15919
@steveklabnik steveklabnik mentioned this pull request May 13, 2015
Closed
@steveklabnik
Copy link
Member

This still doesn't work, and caused the rollup to fail http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4955/steps/test/logs/stdio

@steveklabnik
Copy link
Member

@bors: r-

@bombless
Copy link
Contributor Author

Mac again... so the bug still exist on Mac OSX in a different form, closing this PR.

@bombless bombless closed this May 13, 2015
@Manishearth
Copy link
Member

It's not a mac issue; it's a 32bit vs 64bit issue.

(mac is just the fastest builder and fails first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed length array type with high un-suffixed count literal incorrectly treated as negative count
8 participants
@bombless @rust-highfive @pnkfelix @Manishearth @bors @steveklabnik @oli-obk @brson