Rollup of 12 pull requests #140695
Merged
Rollup of 12 pull requests #140695
+2,324
−755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the public `CommandEnvs` into the `process` module (and make it a wrapper type for an internal iterator type) and everything else into `sys::process` as per rust-lang#117276.
This fixes issues with RustAnalyzer not finding stable_mir crate. It is also part of the long term architecture plan for these crates, since we are moving towards having stable_mir depend on rustc_smir and not the other way around. I believe this is an utility function that will come handy eventually for stable_mir users, but I'm keeping it as part of rustc_internal since it initializes the StableMir context and requires `TyCtxt`. Finally, I added the rustc_internal crate under a feature since the APIs from this module shall not be stabilized.
…at the top level
…f files at the top level
…s at the top level
Co-authored-by: Jubilee <workingjubilee@gmail.com>
This is a routine update to pull in some fixes and updates. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0449
This also causes the coverage-dump unit tests to run in CI and `./x test` by default.
Actually printing the filenames is deferred to a subsequent commit that will simultaneously bless all affected tests.
rustbot
added
A-run-make
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7295b08 (parent) -> 651e9cf (this PR) Test differencesShow 2291 test diffsStage 1
Stage 2
(and 1301 additional test diffs) Additionally, 890 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 651e9cf327358b28db7e37a2ae61727f4a2ef232 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 7295b08a17 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 6, 2025
This was referenced May 6, 2025
|
Finished benchmarking commit (651e9cf): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 0.5%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.005s -> 771.17s (0.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Zremap-path-scopermeta handling #139550 (Fix-Zremap-path-scopermeta handling)Iterator::lastforvec::IntoIter#139773 (ImplementIterator::lastforvec::IntoIter)sys_common::process#140393 (std: get rid ofsys_common::process)stable_mircrate #140532 (Fix RustAnalyzer discovery of rustc'sstable_mircrate)utf8_chunksandIterator::take#140598 (Steer docs toutf8_chunksandIterator::take)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup