Steer docs to utf8_chunks and Iterator::take
#140598
Conversation
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
|
I have never seen "lfold", only "foldl". I am aware that Rust has rfold but every other usage I know of (Haskell, etc.) has it as foldr. I have also never seen either lfind or findl. The primary use-case of these aliases is for relating idioms and functions from beyond Rust, not Rust-to-Rust, and even then they are focused on relatively common idioms and not exhaustively documenting every single language's terminology in our aliases. So I do not think we should add things "for symmetry", and would prefer to review the rest of the changes on their own merit, without such "for symmetry" changes included. |
|
I have other thoughts about those aliases but going on seems unnecessary if that is sufficient as explanation? In particular, I do think the "limit" alias is well-motivated, though I will still have to review it in light of the doc alias policy. And obviously the |
|
Tbh I just saw Original PR description for context:
|
|
I do understand the desire to complete the pattern. I have spent an unnecessary amount of time making sure that |
|
the existence of io::Take::limit is seriously testing my patience with the 1.0 Rust io/fs code. |
workingjubilee
changed the title
utf8_chunks and Iterator::take
|
I just looked at the clash of the fifteen zillion documented instances of @bors r+ rollup |
bors
added
S-waiting-on-bors
…bilee Steer docs to `utf8_chunks` and `Iterator::take` - Adds `limit` as an alias of `take` (as this is [what Java calls this operation](https://docs.oracle.com/javase/8/docs/api/java/util/stream/Stream.html#limit-long-)); - Says that [`Utf8Chunks`](https://doc.rust-lang.org/std/str/struct.Utf8Chunks.html) comes from [`[u8]::utf8_chunks`](https://doc.rust-lang.org/std/primitive.slice.html#method.utf8_chunks). `@rustbot` label +A-docs
Rollup of 12 pull requests Successful merges: - rust-lang#139550 (Fix `-Zremap-path-scope` rmeta handling) - rust-lang#139773 (Implement `Iterator::last` for `vec::IntoIter`) - rust-lang#140035 (Implement RFC 3503: frontmatters) - rust-lang#140176 (Fix linking statics on Arm64EC) - rust-lang#140251 (coverage-dump: Resolve global file IDs to filenames) - rust-lang#140393 (std: get rid of `sys_common::process`) - rust-lang#140532 (Fix RustAnalyzer discovery of rustc's `stable_mir` crate) - rust-lang#140598 (Steer docs to `utf8_chunks` and `Iterator::take`) - rust-lang#140634 (Use more accurate ELF flags on MIPS) - rust-lang#140673 (Clean rustdoc tests folder) - rust-lang#140678 (Be a bit more relaxed about not yet constrained infer vars in closure upvar analysis) - rust-lang#140687 (Update mdbook to 0.4.49) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 12 pull requests Successful merges: - rust-lang#139550 (Fix `-Zremap-path-scope` rmeta handling) - rust-lang#139764 (Consistent trait bounds for ExtractIf Debug impls) - rust-lang#139773 (Implement `Iterator::last` for `vec::IntoIter`) - rust-lang#140035 (Implement RFC 3503: frontmatters) - rust-lang#140251 (coverage-dump: Resolve global file IDs to filenames) - rust-lang#140393 (std: get rid of `sys_common::process`) - rust-lang#140532 (Fix RustAnalyzer discovery of rustc's `stable_mir` crate) - rust-lang#140598 (Steer docs to `utf8_chunks` and `Iterator::take`) - rust-lang#140634 (Use more accurate ELF flags on MIPS) - rust-lang#140673 (Clean rustdoc tests folder) - rust-lang#140678 (Be a bit more relaxed about not yet constrained infer vars in closure upvar analysis) - rust-lang#140687 (Update mdbook to 0.4.49) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#140598 - ShE3py:iter-misc-docs, r=workingjubilee Steer docs to `utf8_chunks` and `Iterator::take` - Adds `limit` as an alias of `take` (as this is [what Java calls this operation](https://docs.oracle.com/javase/8/docs/api/java/util/stream/Stream.html#limit-long-)); - Says that [`Utf8Chunks`](https://doc.rust-lang.org/std/str/struct.Utf8Chunks.html) comes from [`[u8]::utf8_chunks`](https://doc.rust-lang.org/std/primitive.slice.html#method.utf8_chunks). ``@rustbot`` label +A-docs
limitas an alias oftake(as this is what Java calls this operation);Utf8Chunkscomes from[u8]::utf8_chunks.@rustbot label +A-docs