Clippy subtree update #119013

flip1995 · 2023-12-16T13:15:23Z

r? @matthiaskrgr (As Manish wrote that he is a bit inactive until the new year)

and add more test cases

@y21

Thanks @y21 for the hint!

& apply review suggestions;

add more test cases with `match`; minor fixes in message output regarding review feedback

Before this fix, the lint had a false positive, namely when a reference was taken to a field when the field operand implements a custom Drop. The compiler will refuse to partially move a type that implements Drop, because that would put the operand in a weird state. See added regression test.

…ilstrieb Stabilize C string literals RFC: https://rust-lang.github.io/rfcs/3348-c-str-literal.html Tracking issue: rust-lang#105723 Documentation PR (reference manual): rust-lang/reference#1423 # Stabilization report Stabilizes C string and raw C string literals (`c"..."` and `cr#"..."#`), which are expressions of type [`&CStr`](https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html). Both new literals require Rust edition 2021 or later. ```rust const HELLO: &core::ffi::CStr = c"Hello, world!"; ``` C strings may contain any byte other than `NUL` (`b'\x00'`), and their in-memory representation is guaranteed to end with `NUL`. ## Implementation Originally implemented by PR rust-lang#108801, which was reverted due to unintentional changes to lexer behavior in Rust editions < 2021. The current implementation landed in PR rust-lang#113476, which restricts C string literals to Rust edition >= 2021. ## Resolutions to open questions from the RFC * Adding C character literals (`c'.'`) of type `c_char` is not part of this feature. * Support for `c"..."` literals does not prevent `c'.'` literals from being added in the future. * C string literals should not be blocked on making `&CStr` a thin pointer. * It's possible to declare constant expressions of type `&'static CStr` in stable Rust (as of v1.59), so C string literals are not adding additional coupling on the internal representation of `CStr`. * The unstable `concat_bytes!` macro should not accept `c"..."` literals. * C strings have two equally valid `&[u8]` representations (with or without terminal `NUL`), so allowing them to be used in `concat_bytes!` would be ambiguous. * Adding a type to represent C strings containing valid UTF-8 is not part of this feature. * Support for a hypothetical `&Utf8CStr` may be explored in the future, should such a type be added to Rust.

…ubtree-sync

new lint: `repeat_vec_with_capacity` Closes rust-lang#11537 [Lint description](https://github.com/y21/rust-clippy/blob/repeat_vec_with_capacity/clippy_lints/src/repeat_vec_with_capacity.rs#L14) should explain this PR :) changelog: new lint: `repeat_vec_with_capacity`

[`missing_asserts_for_indexing`]: accept length equality checks Fixes rust-lang#11835 The lint now allows indexing with indices 0 and 1 when an `assert!(x.len() == 2);` is found. (Also fixed a typo in the doc example) changelog: [`missing_asserts_for_indexing`]: accept len equality checks as a valid assertion

Because the variant name in `Level` is `Note`, and the `without_error` suffix is omitted in similar cases like `struct_allow` and `struct_help`.

…bug`. Because the corresponding `Level` is `DelayedBug` and `span_delayed_bug` follows the pattern used everywhere else: `span_err`, `span_warning`, etc.

…r=compiler-errors Cleanup error handlers Mostly by making function naming more consistent. More to do after this, but this is enough for one PR. r? compiler-errors

…hiaskrgr Clippy subtree sync r? `@Manishearth`

Avoid scanning temporary files created by editors like this one created by Vim: ---- old_test_headers stdout ---- thread 'old_test_headers' panicked at tests/headers.rs:19:74: tests/ui/.regex.rs.swp: stream did not contain valid UTF-8 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

expending lint [`blocks_in_if_conditions`] to check match expr as well closes: rust-lang#11814 changelog: rename lint `blocks_in_if_conditions` to [`blocks_in_conditions`] and expand it to check blocks in match scrutinees

Do not check twice whether `qpath` is a `QPath::TypeRelative` variant This is a style fix: the outer `if` check was useless. changelog: none

Tolerate hidden, binary files in tests/ Avoid scanning temporary files created by editors like this one created by Vim: ---- old_test_headers stdout ---- thread 'old_test_headers' panicked at tests/headers.rs:19:74: tests/ui/.regex.rs.swp: stream did not contain valid UTF-8 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace changelog: none

It's hard to check whether oprator is overrided through context of lint So assume nontrivial has overrided binary operator

From the regex v1.10.0 release notes [1]: This is a new minor release of regex that adds support for start and end word boundary assertions. [...] The new word boundary assertions are: • \< or \b{start}: a Unicode start-of-word boundary (\W|\A on the left, \w on the right). • \> or \b{end}: a Unicode end-of-word boundary (\w on the left, \W|\z on the right)). • \b{start-half}: half of a Unicode start-of-word boundary (\W|\A on the left). • \b{end-half}: half of a Unicode end-of-word boundary (\W|\z on the right). [1]: https://github.com/rust-lang/regex/blob/master/CHANGELOG.md#1100-2023-10-09

close rust-lang#11066 close rust-lang#11665 close rust-lang#11911

Check whether operator is overrided with a `struct` operand. The struct here refers to `struct`, `enum`, `union`. Add and fix test for `no_effect` lint.

Rustup r? `@ghost` changelog: none

rustbot · 2023-12-16T13:15:33Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2023-12-16T13:16:16Z

Could not assign reviewer from: matthiaskrgr.
User(s) matthiaskrgr are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

flip1995 · 2023-12-16T13:16:58Z

Whoops, messed up the PR name (not on my usual workstation where this is automated). Fixed it and removed the labels.

flip1995 · 2023-12-16T13:17:33Z

r? @Manishearth

matthiaskrgr · 2023-12-16T13:44:44Z

huh weird, I'll check in an hour or two when I'm back home

Manishearth · 2023-12-16T14:48:47Z

@bors r+

bors · 2023-12-16T14:48:50Z

📌 Commit b92ab50 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2023-12-16T14:50:03Z

⌛ Testing commit b92ab50 with merge e223c41...

bors · 2023-12-16T16:47:20Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing e223c41 to master...

rust-timer · 2023-12-16T18:07:19Z

Finished benchmarking commit (e223c41): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-1.9%	[-2.6%, -1.1%]	2
Improvements ✅ (secondary)	-3.6%	[-3.6%, -3.6%]	1
All ❌✅ (primary)	-0.6%	[-2.6%, 1.9%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.7%, -0.4%]	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.7%, -0.4%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.699s -> 672.461s (-0.04%)
Artifact size: 312.43 MiB -> 312.46 MiB (0.01%)

jmillikin and others added 30 commits November 1, 2023 09:16

Stabilize C string literals

e3a1555

implement unoptimized code logic for [infinite_loops]

2d9fc6d

[missing_asserts_for_indexing]: accept len equality checks

4de845e

stop warning never-returning calls

3e9a6d1

and add more test cases

eliminate the second visit to save a bit performance.

0d26f91

Thanks @y21 for the hint!

change name to [infinite_loop];

758d0e8

& apply review suggestions;

expending lint [blocks_in_if_conditions] to check match expr as well

fff7aa0

rename [blocks_in_if_conditions] to [blocks_in_conditions];

40b558a

add more test cases with `match`; minor fixes in message output regarding review feedback

Do not check twice whether qpath is a QPath::TypeRelative variant

6275e77

new lint: repeat_vec_with_capacity

5049415

use iter::repeat_with in suggestion and add examples

76eb781

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-s…

c9a43b1

…ubtree-sync

Rename *note_without_error as *note.

dc702e3

Because the variant name in `Level` is `Note`, and the `without_error` suffix is omitted in similar cases like `struct_allow` and `struct_help`.

Rename HandlerInner::delay_span_bug as `HandlerInner::span_delayed_…

8dab738

…bug`. Because the corresponding `Level` is `DelayedBug` and `span_delayed_bug` follows the pattern used everywhere else: `span_err`, `span_warning`, etc.

Auto merge of rust-lang#118470 - nnethercote:cleanup-error-handlers, …

30f8e87

…r=compiler-errors Cleanup error handlers Mostly by making function naming more consistent. More to do after this, but this is enough for one PR. r? compiler-errors

Auto merge of rust-lang#118507 - flip1995:clippy-subtree-sync, r=matt…

c586717

…hiaskrgr Clippy subtree sync r? `@Manishearth`

Auto merge of rust-lang#11853 - J-ZhengLi:issue11814, r=llogiq

75bdbfc

expending lint [`blocks_in_if_conditions`] to check match expr as well closes: rust-lang#11814 changelog: rename lint `blocks_in_if_conditions` to [`blocks_in_conditions`] and expand it to check blocks in match scrutinees

Auto merge of rust-lang#11899 - samueltardieu:redundant-if, r=llogiq

31aa0b2

Do not check twice whether `qpath` is a `QPath::TypeRelative` variant This is a style fix: the outer `if` check was useless. changelog: none

Add a function to check whether binary oprands are nontrivial

6d40b10

It's hard to check whether oprator is overrided through context of lint So assume nontrivial has overrided binary operator

fix: handle std::ptr::null{_mut}

8eea8b1

close rust-lang#11066 close rust-lang#11665 close rust-lang#11911

Parse a pattern with no arm

7ffe1ff

docs(explicit_write): add missing backtick to complete code snippet

a3ce379

Rewrite logic of has_nontrivial_oprand.

8977423

Check whether operator is overrided with a `struct` operand. The struct here refers to `struct`, `enum`, `union`. Add and fix test for `no_effect` lint.

flip1995 and others added 5 commits December 16, 2023 13:59

Merge remote-tracking branch 'upstream/master' into rustup

80ccd63

Bump nightly version -> 2023-12-16

71f48ee

Auto merge of rust-lang#11971 - flip1995:rustup, r=flip1995

a859e5c

Rustup r? `@ghost` changelog: none

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

61f4a73

Update Cargo.lock

b92ab50

rustbot assigned matthiaskrgr Dec 16, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2023

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2023

This comment was marked as resolved.

Sign in to view

flip1995 changed the title ~~Clippy subtree sync~~ Clippy subtree update Dec 16, 2023

flip1995 removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Dec 16, 2023

rustbot assigned Manishearth and unassigned matthiaskrgr Dec 16, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2023

bors merged commit e223c41 into rust-lang:master Dec 16, 2023

rustbot added this to the 1.76.0 milestone Dec 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clippy subtree update #119013

Clippy subtree update #119013

flip1995 commented Dec 16, 2023

rustbot commented Dec 16, 2023

This comment was marked as resolved.

rustbot commented Dec 16, 2023

flip1995 commented Dec 16, 2023

flip1995 commented Dec 16, 2023

matthiaskrgr commented Dec 16, 2023

Manishearth commented Dec 16, 2023

bors commented Dec 16, 2023

bors commented Dec 16, 2023

bors commented Dec 16, 2023

rust-timer commented Dec 16, 2023

Clippy subtree update #119013

Clippy subtree update #119013

Conversation

flip1995 commented Dec 16, 2023

rustbot commented Dec 16, 2023

This comment was marked as resolved.

rustbot commented Dec 16, 2023

flip1995 commented Dec 16, 2023

flip1995 commented Dec 16, 2023

matthiaskrgr commented Dec 16, 2023

Manishearth commented Dec 16, 2023

bors commented Dec 16, 2023

bors commented Dec 16, 2023

bors commented Dec 16, 2023

rust-timer commented Dec 16, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size