Skip to content

Upgrade LLVM #11853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Upgrade LLVM #11853

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

This upgrade brings commit by @eddyb to help optimizations of virtual calls in
a few places (llvm-mirror/llvm@6d2bd95) as well as a
commit by @c-a to greatly improve the runtime of the optimization passes
(rust-lang/llvm#3).

Nice work to these guys!

@brson
Copy link
Contributor

brson commented Jan 28, 2014

r+

@brson
Copy link
Contributor

brson commented Jan 28, 2014

This doesn't touch the clean trigger.

@c-a
Copy link
Contributor

c-a commented Jan 28, 2014

Do the builders set LLVM_FORCE_USE_OLD_TOOLCHAIN? If so, this was probably broken by rust-lang/llvm@55e6c61. It renamed the option to LLVM_FORCE_USE_OLD_HOST_TOOLCHAIN but didn't update the code that tests for LLVM_FORCE_USE_OLD_TOOLCHAIN.

@c-a
Copy link
Contributor

c-a commented Jan 28, 2014

Sent a mail to llvm-commits about the option change: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140127/202996.html

@c-a
Copy link
Contributor

c-a commented Jan 28, 2014

Heh, on further inspection we use autoconf and not CMake to build llvm. So since rust-lang/llvm@7ba06ed we either need to update the compiler versions on the failing buildbots or pass --disable-compiler-version-checks to configure.

@alexcrichton
Copy link
Member Author

Pushing this through try, it looks like we can build on the bots with --disable-compiler-version-checks, so I'm turning that on for now.

We'll probably need to look into upgrading the bots in the near future, however.

@alexcrichton
Copy link
Member Author

Turns out LLVM changed how the dllexport "linkage" was set on global values, who knew!

This upgrade brings commit by @eddyb to help optimizations of virtual calls in
a few places (llvm-mirror/llvm@6d2bd95) as well as a
commit by @c-a to *greatly* improve the runtime of the optimization passes
(rust-lang/llvm#3).

Nice work to these guys!
bors added a commit that referenced this pull request Jan 30, 2014
This upgrade brings commit by @eddyb to help optimizations of virtual calls in
a few places (llvm-mirror/llvm@6d2bd95) as well as a
commit by @c-a to *greatly* improve the runtime of the optimization passes
(rust-lang/llvm#3).

Nice work to these guys!
@bors bors closed this Jan 30, 2014
@alexcrichton alexcrichton deleted the up-llvm branch January 30, 2014 17:44
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 16, 2023
expending lint [`blocks_in_if_conditions`] to check match expr as well

closes: rust-lang#11814

changelog: rename lint `blocks_in_if_conditions` to [`blocks_in_conditions`] and expand it to check blocks in match scrutinees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants