Skip to content

Deletion of unused UseBackgroundThreadsForIO #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions projects/RabbitMQ.Client/client/api/ConnectionFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,6 @@ public AmqpTcpEndpoint Endpoint
/// </summary>
public TimeSpan RequestedHeartbeat { get; set; } = DefaultHeartbeat;

/// <summary>
/// When set to true, background thread will be used for the I/O loop.
/// </summary>
public bool UseBackgroundThreadsForIO { get; set; }

/// <summary>
/// Username to use when authenticating to the server.
/// </summary>
Expand Down
5 changes: 0 additions & 5 deletions projects/RabbitMQ.Client/client/api/IConnectionFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,6 @@ public interface IConnectionFactory
/// </summary>
TimeSpan RequestedHeartbeat { get; set; }

/// <summary>
/// When set to true, background threads will be used for I/O and heartbeats.
/// </summary>
bool UseBackgroundThreadsForIO { get; set; }

/// <summary>
/// Username to use when authenticating to the server.
/// </summary>
Expand Down
4 changes: 2 additions & 2 deletions projects/RabbitMQ.Client/client/impl/Connection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public Connection(IConnectionFactory factory, bool insist, IFrameHandler frameHa
_session0 = new MainSession(this) { Handler = NotifyReceivedCloseOk };
_model0 = (ModelBase)Protocol.CreateModel(_session0);

StartMainLoop(factory.UseBackgroundThreadsForIO);
StartMainLoop();
Open(insist);
}

Expand Down Expand Up @@ -830,7 +830,7 @@ public void MaybeStartHeartbeatTimers()
}
}

public void StartMainLoop(bool useBackgroundThread)
public void StartMainLoop()
{
_mainLoopTask = Task.Run((Action)MainLoop);
}
Expand Down
2 changes: 0 additions & 2 deletions projects/Unit/APIApproval.Approve.verified.txt
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ namespace RabbitMQ.Client
public RabbitMQ.Client.SslOption Ssl { get; set; }
public bool TopologyRecoveryEnabled { get; set; }
public System.Uri Uri { get; set; }
public bool UseBackgroundThreadsForIO { get; set; }
public string UserName { get; set; }
public string VirtualHost { get; set; }
public static System.Net.Sockets.AddressFamily DefaultAddressFamily { get; set; }
Expand Down Expand Up @@ -330,7 +329,6 @@ namespace RabbitMQ.Client
uint RequestedFrameMax { get; set; }
System.TimeSpan RequestedHeartbeat { get; set; }
System.Uri Uri { get; set; }
bool UseBackgroundThreadsForIO { get; set; }
string UserName { get; set; }
string VirtualHost { get; set; }
RabbitMQ.Client.IAuthMechanismFactory AuthMechanismFactory(System.Collections.Generic.IList<string> mechanismNames);
Expand Down
69 changes: 0 additions & 69 deletions projects/Unit/TestConnectionWithBackgroundThreads.cs

This file was deleted.