Deletion of unused UseBackgroundThreadsForIO #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pliner
force-pushed
the
drop-unused-use-background-threads-for-io
branch
from
c3680f8 to
be24c05
Compare
Pliner
changed the title
|
@bording @lukebakken @stebet just to be sure: if we include this into |
|
@Pliner good catch, thanks. |
Yes, this is a breaking change. It should not be backported to 6.x |
|
It's a no-op but yes, breaking as removing it'll trigger a compilation error. I'd say for 6.x mark it with a [Deprecated] attribute. |
|
Actually this was not backported to |
adamsitnik
added a commit
to adamsitnik/AspNetCore.Diagnostics.HealthChecks
that referenced
this pull request
Nov 23, 2023
… and removed (it was unused), see rabbitmq/rabbitmq-dotnet-client#846 for more details
adamsitnik
added a commit
to Xabaril/AspNetCore.Diagnostics.HealthChecks
that referenced
this pull request
Dec 4, 2023
* update all dependencies that don't require TFM update to latest versions * build fix: fix xUnit1030 in the whole solution: don't use .GetAwaiter in Test projects * build fix: stop using UseBackgroundThreadsForIO, which got deprecated and removed (it was unused), see rabbitmq/rabbitmq-dotnet-client#846 for more details * build fix: xUnit1031: Test methods should not use blocking task operations, as they can cause deadlocks. * update all dependencies that required TFM bump to .NET 8 * build fix: stop using .Add, use .Append instead * run approval tests for 8, not 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Delettion of unused property
UseBackgroundThreadsForIO.Types of Changes
Checklist
CONTRIBUTING.mddocument