Skip to content

Only lint the first argument of expect_true() for expect_comparison_linter() #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2083

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a716e1a) 98.64% compared to head (774605e) 98.64%.

❗ Current head 774605e differs from pull request most recent head 6ebdd67. Consider uploading reports for the commit 6ebdd67 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2408   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         126      126           
  Lines        5623     5623           
=======================================
  Hits         5547     5547           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 3fd90ba into main Dec 9, 2023
@IndrajeetPatil IndrajeetPatil deleted the ec-info branch December 9, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect_comparison_linter() gets bad metadata for faulty expect_true() usage
3 participants