only lint the first argument of expect_true (#2408)

Author: MichaelChirico

NEWS.md

@@ -68,6 +68,7 @@
   + ignores extractions with explicit returns like `lapply(l, function(x) foo(x)$bar)` (#2258, @MichaelChirico).
   + ignores calls on the RHS of operators like `lapply(l, function(x) "a" %in% names(x))` (#2310, @MichaelChirico).
 * `vector_logic_linter()` recognizes some cases where bitwise `&`/`|` are used correctly (#1453, @MichaelChirico).
+* `expect_comparison_linter()` ignores faulty usage like `expect_true(x, y > z)` (#2083, @MichaelChirico). Note that `y > z` is being passed to the `info=` argument, so this is likely a mistake.
 
 ### Lint accuracy fixes: removing false negatives
 

R/expect_comparison_linter.R

@@ -53,7 +53,7 @@ expect_comparison_linter <- function() {
   xpath <- glue("
   //SYMBOL_FUNCTION_CALL[text() = 'expect_true']
     /parent::expr
-    /following-sibling::expr[ {xp_or(comparator_nodes)} ]
+    /following-sibling::expr[1][ {xp_or(comparator_nodes)} ]
     /parent::expr[not(SYMBOL_SUB[text() = 'info'])]
   ")
 

tests/testthat/test-expect_comparison_linter.R

@@ -11,6 +11,9 @@ test_that("expect_comparison_linter skips allowed usages", {
 
   # expect_gt() and friends don't have an info= argument
   expect_lint("expect_true(x > y, info = 'x is bigger than y yo')", NULL, linter)
+
+  # expect_true() used incorrectly, and as executed the first argument is not a lint
+  expect_lint("expect_true(is.count(n_draws), n_draws > 1)", NULL, linter)
 })
 
 test_that("expect_comparison_linter blocks simple disallowed usages", {