Skip to content

Extend allow_filter in conjunct_test_linter() to allow linting only dplyr::filter() (i.e. qualified) #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2078

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #2169 (1b86e1d) into main (8cdf26c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1b86e1d differs from pull request most recent head 36f04dc. Consider uploading reports for the commit 36f04dc to get more accurate results

@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         112      112           
  Lines        5117     5122    +5     
=======================================
+ Hits         5099     5104    +5     
  Misses         18       18           
Files Changed Coverage Δ
R/conjunct_test_linter.R 100.00% <100.00%> (ø)

@MichaelChirico MichaelChirico merged commit 5f18b79 into main Sep 14, 2023
@MichaelChirico MichaelChirico deleted the allow-filter branch September 14, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider ways to work around stats::filter() when applying dplyr::filter() lints
3 participants