Merge branch 'main' into allow-filter

Author: MichaelChirico

NEWS.md

@@ -57,7 +57,7 @@
 
 ### New linters
 
-* `library_call_linter()` can detect if all library/require calls are not at the top of your script (#2027 and #2043, @nicholas-masel and @MichaelChirico).
+* `library_call_linter()` can detect if all library/require calls are not at the top of your script (#2027, #2043, and #2163, @nicholas-masel and @MichaelChirico).
 * `keyword_quote_linter()` for finding unnecessary or discouraged quoting of symbols in assignment, function arguments, or extraction (part of #884, @MichaelChirico). Quoting is unnecessary when the target is a valid R name, e.g. `c("a" = 1)` can be `c(a = 1)`. The same goes to assignment (`"a" <- 1`) and extraction (`x$"a"`). Where quoting is necessary, the linter encourages doing so with backticks (e.g. `` x$`a b` `` instead of `x$"a b"`).
 * `length_levels_linter()` for using the specific function `nlevels()` instead of checking `length(levels(x))` (part of #884, @MichaelChirico).
 * `scalar_in_linter()` for discouraging `%in%` when the right-hand side is a scalar, e.g. `x %in% 1` (part of #884, @MichaelChirico).

R/library_call_linter.R

@@ -48,7 +48,7 @@ library_call_linter <- function() {
   xpath <- glue("
     //SYMBOL_FUNCTION_CALL[{ attach_call }][last()]
       /preceding::expr
-      /SYMBOL_FUNCTION_CALL[not({ attach_call })][last()]
+      /SYMBOL_FUNCTION_CALL[not({ attach_call } or starts-with(text(), 'suppress'))][last()]
       /following::expr[SYMBOL_FUNCTION_CALL[{ attach_call }]]
       /parent::expr
   ")

tests/testthat/test-library_call_linter.R

@@ -32,6 +32,17 @@ test_that("library_call_linter skips allowed usages", {
     NULL,
     linter
   )
+
+  expect_lint(
+    trim_some("
+      suppressPackageStartupMessages({
+        library(dplyr)
+        library(knitr)
+      })
+    "),
+    NULL,
+    linter
+  )
 })
 
 test_that("library_call_linter warns on disallowed usages", {
@@ -108,6 +119,17 @@ test_that("library_call_linter warns on disallowed usages", {
     lint_message,
     linter
   )
+
+  expect_lint(
+    trim_some("
+      library(dplyr)
+      print('test')
+      suppressMessages(library(tidyr))
+      print('test')
+    "),
+    lint_message,
+    linter
+  )
 })
 
 test_that("require() treated the same as library()", {