update the default collation of GBK from gbk_bin to gbk_chinese_ci #20234
Conversation
Oreoxmt
added
type/bugfix
ti-chi-bot
bot
added
the
size/M
| +---------+-------------------------------------+-------------------+--------+ | ||
| | ascii | US ASCII | ascii_bin | 1 | | ||
| | binary | binary | binary | 1 | | ||
| | gbk | Chinese Internal Code Specification | gbk_chinese_ci | 2 | |
There was a problem hiding this comment.
TiDB has supported GB18030 (master only now, not released in any version yet) pingcap/tidb#55792 . Similar with gbk, its default collation is gb18030_chinese_ci when by default but gb18030_bin if new collation is not enabled. FWD @CbcWestwolf
|
@lcwangchao: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hfxsd
added
translation/done
[LGTM Timeline notifier]Timeline:
|
|
@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
update the default collation of GBK from gbk_bin to gbk_chinese_ci
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?