-
Notifications
You must be signed in to change notification settings - Fork 533
DOC: Add S3DataGrabber example #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
==========================================
- Coverage 67.47% 62.88% -4.59%
==========================================
Files 341 339 -2
Lines 43362 43311 -51
Branches 5379 5095 -284
==========================================
- Hits 29257 27236 -2021
- Misses 13409 15039 +1630
- Partials 696 1036 +340
Continue to review full report at Codecov.
|
@TimVanMourik ( here is an example of s3 datagrabber ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP8 issues identified by Codacy.
Thanks for this example. The |
Going to go ahead and merge this. @wtriplett Feel free to open a pull request with an improved (or, better, another) example. |
@TimVanMourik were you able to use this to create an s3datagrabber example? i'm not completely sure how i would initialize the s3datagrabber appropriately with giraffe. @wtriplett - it would be nice to add a regex example. i just wanted to get an example in, since there were none :) |
1.1.8 (January 28, 2019) * FIX: ANTS LaplacianThickness cmdline opts fixed up (nipy#2846) * FIX: Resolve LinAlgError during SVD (nipy#2838) * ENH: Add interfaces wrapping DIPY worflows (nipy#2830) * ENH: Update BIDSDataGrabber for pybids 0.7 (nipy#2737) * ENH: Add FSL `eddy_quad` interface (nipy#2825) * ENH: Support tckgen -select in MRtrix3 v3+ (nipy#2823) * ENH: Support for BIDS event files (nipy#2845) * ENH: CompositeTransformUtil, new ANTs interface (nipy#2785) * RF: Move pytest and pytest-xdist from general requirement into tests_required (nipy#2850) * DOC: Add S3DataGrabber example (nipy#2849) * DOC: Skip conftest module in API generation (nipy#2852) * DOC: Hyperlink DOIs to preferred resolver (nipy#2833) * MAINT: Install numpy!=1.16.0 from conda in Docker (nipy#2862) * MAINT: Drop pytest-xdist requirement, minimum pytest version (nipy#2856) * MAINT: Disable numpy 1.16.0 for Py2.7 (nipy#2855) * tag '1.1.8': (79 commits) MNT: Add @feilong to .zenodo, update ordering MNT: Update .mailmap MNT: Update .zenodo ordering Accept invitation as Zenodo release co-author (see nipy#2864) MAINT: Update .mailmap BF: allowing bids_event_file as alternate input MNT: Update .zenodo ordering MNT: Version 1.1.8 DOC: 1.1.8 changelog Update nipype/interfaces/dipy/tracks.py Update nipype/interfaces/dipy/reconstruction.py MNT: Install numpy!=1.16.0 from conda in Docker Add FSL auto test remake specs Update nipype/interfaces/io.py Remove return type named tuple Update nipype/info.py STY: Whitespace, line length Remove out_ prefix from EddyQuad outputs Apply minor edits from code review ...
Sorry for the delay. Yes, made an example: This example:
All Nipype modules that requires dynamic inputs/outputs are a bit cumbersome in GiraffeTools, but can be dealt with by adding ports manually. It is a bit contrary to the philosophy though, as I like to think of functions as static. |
this is to improve usage of s3 data grabber.
several examples here: https://github.com/kellyhennigan/cueexp_scripts/blob/25372d4f221762af6d79d1af67a8570f2c546b20/svmrfe/venv/lib64/python2.7/site-packages/nipype/interfaces/tests/test_io.py
Acknowledgment