[ENH] Update BIDSDataGrabber for pybids 0.7 #2737

adelavega · 2018-10-15T17:52:08Z

This PR updates BIDSDataGrabber for pybids 0.7.

Updated defunct bids entities (e.g. modality)
Changed default query to be more specific (T1w vs anat; bold vs func)
Added derivatives handling (two inputs traits, boolean derivatives and option to add other directories)
Updated tests
Minor: Removed outfields from examples, as they are dynamically generated.

Need to wait for pybids to officially release 0.7 (and pin version), before merging.

…es handling

effigies · 2018-10-16T21:45:01Z

nipype/interfaces/io.py

+                "bold": {"datatype": "func", "suffix": "bold",
+                         "extensions": ["nii", ".nii.gz"]},
+                "T1w": {"datatype": "anat", "suffix": "T1w",
+                         "extensions": ["nii", ".nii.gz"]},


Not a problem for this PR, but we may want to think about making it a much more generally usable default.

Sure. Such as? you mean returning more things?

Yeah. Ideally something that will contain most, if not all, files, and can just be queried sensibly. I feel like specifying the query is more of a power-user move, so making sure there's a reasonable way to ask for the files most people will want would be good.

That sounds good to me, although I worry about about performance if a bunch of unnecessary queries are made. Although the indexing itself is probably the slowest part, so it should probably be fine.

While we're at it, other fields you'd want? brain_mask is another one I can think of for fmri. I would like to hear from ppl doing preprocessing and and DWI as I'm unfamiliar with what is typically expected.

codecov-io · 2018-10-16T22:08:32Z

Codecov Report

Merging #2737 into master will decrease coverage by 3.35%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   67.38%   64.02%   -3.36%     
==========================================
  Files         341      339       -2     
  Lines       43474    43412      -62     
  Branches     5401     5398       -3     
==========================================
- Hits        29294    27795    -1499     
- Misses      13482    14544    +1062     
- Partials      698     1073     +375

Flag	Coverage Δ
#smoketests	`?`
#unittests	`64.02% <83.33%> (-0.77%)`	⬇️

Impacted Files	Coverage Δ
nipype/info.py	`87.87% <ø> (-6.07%)`	⬇️
nipype/interfaces/io.py	`48.62% <83.33%> (-5.37%)`	⬇️
nipype/interfaces/nilearn.py	`40% <0%> (-56.67%)`	⬇️
nipype/utils/spm_docs.py	`25.92% <0%> (-44.45%)`	⬇️
nipype/interfaces/freesurfer/base.py	`50% <0%> (-30.51%)`	⬇️
nipype/utils/logger.py	`59.7% <0%> (-29.86%)`	⬇️
nipype/algorithms/rapidart.py	`35% <0%> (-29.42%)`	⬇️
nipype/interfaces/spm/base.py	`58.08% <0%> (-29.05%)`	⬇️
nipype/utils/provenance.py	`55.73% <0%> (-28.35%)`	⬇️
nipype/interfaces/fsl/model.py	`55.26% <0%> (-25.35%)`	⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b74fd2...b623cdd. Read the comment docs.

adelavega · 2018-10-16T22:09:02Z

Hopefully the tests will pass now. Otherwise, any other reviews? Either way, waiting for pybids 0.7 but aside from that I'm done.

effigies · 2018-12-14T02:38:09Z

Put on 1.1.8 milestone, as I expect pybids 0.7 will be out by then. Also, we should coordinate with @jdkent and #2815 on a mutually satisfactory version of this interface.

adelavega · 2018-12-14T17:04:08Z

Waiting for pybids 0.7 release. Need to re-test and update the pin when that happens.

adelavega · 2019-01-11T21:10:11Z

Looks like tests are passing, but building docs have failed. Not my fault, promise!

effigies · 2019-01-13T14:31:26Z

Please merge master to fix tests.

@jdkent Can you review this in light of your thoughts in #2815?

effigies

@adelavega A few comments. @jdkent I'd still appreciate your input when you get time.

effigies · 2019-01-13T22:04:27Z

.travis.yml

- travis_retry pip install grabbit==0.1.2
- travis_retry git clone -b 0.6.5 https://github.com/INCF/pybids.git ${HOME}/pybids && pip install -e ${HOME}/pybids
+- travis_retry pip install grabbit==0.2.6
+- travis_retry pip install git+https://github.com/bids-standard/pybids.git@0.7.0#egg=pybids


Tests skip unless it's installed in editable mode.

interfaces/tests/test_io.py::test_bids_grabber [gw0] [ 83%] SKIPPED interfaces/tests/test_io.py::test_bids_grabber interfaces/tests/test_io.py::test_bids_fields [gw0] [ 84%] SKIPPED interfaces/tests/test_io.py::test_bids_fields interfaces/tests/test_io.py::test_bids_infields_outfields [gw0] [ 84%] SKIPPED interfaces/tests/test_io.py::test_bids_infields_outfields

That is by design because when you install in editable mode you get the data that is needed for the tests

Right. So we need to switch back to editable.

Oh, I thought it was editable, not sure why that changed.

nipype/info.py

effigies · 2019-01-13T22:07:09Z

nipype/interfaces/io.py

+        True, usedefault=True,
+        desc='Generate exception if list is empty for a given field')
+    return_type = traits.Enum(
+        'file', 'namedtuple', usedefault=True)


Have we tested return_type == 'namedtuple' anywhere? I think this went away in 0.7.0. If we're going to drop backwards compatibility, it might be worth removing this one.

I tested return_type=namedtuple locally with pybids 0.7.0 installed and adelavega's branch of nipype:
code:

from nipype.interfaces.io import BIDSDataGrabber

%%bash datalad install ///openneuro/ds000114

bids_grabber = BIDSDataGrabber(base_dir='ds000114', return_type='namedtuple') res = bids_grabber.run()

I got the following error traceback:

--------------------------------------------------------------------------- ValueError Traceback (most recent call last) <ipython-input-23-001916242d69> in <module> ----> 1 res = bids_grabber.run() ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/nipype/interfaces/base/core.py in run(self, cwd, ignore_exception, **inputs) 369 runtime = self._run_interface(runtime) 370 runtime = self._post_run_hook(runtime) --> 371 outputs = self.aggregate_outputs(runtime) 372 except Exception as e: 373 import traceback ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/nipype/interfaces/base/core.py in aggregate_outputs(self, runtime, needed_outputs) 447 """ 448 --> 449 predicted_outputs = self._list_outputs() 450 outputs = self._outputs() 451 if predicted_outputs: ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/nipype/interfaces/io.py in _list_outputs(self) 2832 args = query.copy() 2833 args.update(filters) -> 2834 filelist = layout.get(return_type=self.inputs.return_type, **args) 2835 if len(filelist) == 0: 2836 msg = 'Output key: %s returned no files' % key ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/bids/layout/layout.py in get(self, return_type, target, extensions, derivatives, regex_search, defined_fields, domains, **kwargs) 422 BIDSLayout, self).get(return_type, target=target, 423 extensions=extensions, domains=None, --> 424 regex_search=regex_search, **ent_kwargs) 425 426 # Search the metadata if needed ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/grabbit/core.py in get(self, return_type, target, extensions, domains, regex_search, **kwargs) 761 762 if target is None: --> 763 raise ValueError('If return_type is "id" or "dir", a valid ' 764 'target entity must also be specified.') 765 result = [x for x in result if target in x.entities] ValueError: If return_type is "id" or "dir", a valid target entity must also be specified.

I'll remove that

You were going to remove namedtuple?

effigies · 2019-01-13T22:08:49Z

nipype/interfaces/io.py

-            bids_config = join(dirname(bidslayout.__file__), 'config', 'bids.json')
+            from bids import layout as bidslayout
+            bids_config = join(
+                dirname(bidslayout.__file__), 'config', 'bids.json')
            bids_config = json.load(open(bids_config, 'r'))
            infields = [i['name'] for i in bids_config['entities']]


Can we replace all of this with BIDSLayout().entities? I'm not a fan of digging through the directory structure of a package unless there are no other options.

That command (BIDSLayout().entities) returned an error for me:
TypeError: __init__() missing 1 required positional argument: 'root'.

I do not know of a better way (but I didn't look extremely hard)

Another comment: I think it would be nice to include derivatives.json (or the derivatives entities) by default as well for queries to be maximally flexible.

Oh, sorry, I meant that in a pseudocode sense of the entities attribute of an instantiated object, not that that snippet would work.

Yeah, maybe I can reorganize this to set up the layout first, before setting the output traits.

Is there any problem with instantiating the layout in __init__?

The biggest problem is that inputs can change between instantiation and running.

That's a pretty big problem!

So I think for now instantiating a layout just to get entities does not work. Adding a helper function to pybids and then changing this later is a better option.

effigies · 2019-01-13T22:11:22Z

nipype/interfaces/io.py

+        'file', 'namedtuple', usedefault=True)
+    index_derivatives = traits.Bool(
+        False, usedefault=True,
+        desc='Index derivatives/ sub-directory')


This should be mandatory=True, since you don't use an isdefined() check on it below. It's possible to pass an Undefined to things with defaults to disable the input, unless mandatory is set True.

effigies · 2019-01-13T22:12:39Z

nipype/interfaces/tests/test_io.py

    assert 'sub-01_task-mixedgamblestask_run-01_bold.nii.gz' in \
-        map(os.path.basename, results.outputs.func)
+        map(os.path.basename, results.outputs.bold)


 @pytest.mark.skipif(not have_pybids,


Can we remove the @pytest.mark.skipif(sys.version_info < (3, 0), lines a couple below, and for the other tests, too? Pybids does still support Python 2, and we should make sure that it works, as long as it does.

Yeah I guess...

jdkent

testing this out using bids queries, this works great, but I couldn't get this interface to track my derivatives.

I think one issue was that I have an older run of fmriprep, and I can't add the outdated entities through this interface (e.g. variant).
I would like to be able to add my own entities (perhaps through the config kwarg in BIDSLayout?)

Another issue appeared to be when I was trying to use add_derivatives with one derivatives directory, it looked like pybids was trying to index all of derivatives (which in my case can sometimes be large and unruly, but I think this may an issue more appropriate for pybids itself).

There are also some minor comments.

jdkent · 2019-01-13T23:38:47Z

nipype/interfaces/io.py

+        True, usedefault=True,
+        desc='Generate exception if list is empty for a given field')
+    return_type = traits.Enum(
+        'file', 'namedtuple', usedefault=True)


I tested return_type=namedtuple locally with pybids 0.7.0 installed and adelavega's branch of nipype:
code:

from nipype.interfaces.io import BIDSDataGrabber

%%bash datalad install ///openneuro/ds000114

bids_grabber = BIDSDataGrabber(base_dir='ds000114', return_type='namedtuple') res = bids_grabber.run()

I got the following error traceback:

--------------------------------------------------------------------------- ValueError Traceback (most recent call last) <ipython-input-23-001916242d69> in <module> ----> 1 res = bids_grabber.run() ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/nipype/interfaces/base/core.py in run(self, cwd, ignore_exception, **inputs) 369 runtime = self._run_interface(runtime) 370 runtime = self._post_run_hook(runtime) --> 371 outputs = self.aggregate_outputs(runtime) 372 except Exception as e: 373 import traceback ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/nipype/interfaces/base/core.py in aggregate_outputs(self, runtime, needed_outputs) 447 """ 448 --> 449 predicted_outputs = self._list_outputs() 450 outputs = self._outputs() 451 if predicted_outputs: ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/nipype/interfaces/io.py in _list_outputs(self) 2832 args = query.copy() 2833 args.update(filters) -> 2834 filelist = layout.get(return_type=self.inputs.return_type, **args) 2835 if len(filelist) == 0: 2836 msg = 'Output key: %s returned no files' % key ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/bids/layout/layout.py in get(self, return_type, target, extensions, derivatives, regex_search, defined_fields, domains, **kwargs) 422 BIDSLayout, self).get(return_type, target=target, 423 extensions=extensions, domains=None, --> 424 regex_search=regex_search, **ent_kwargs) 425 426 # Search the metadata if needed ~/.conda/envs/bids_nipy/lib/python3.6/site-packages/grabbit/core.py in get(self, return_type, target, extensions, domains, regex_search, **kwargs) 761 762 if target is None: --> 763 raise ValueError('If return_type is "id" or "dir", a valid ' 764 'target entity must also be specified.') 765 result = [x for x in result if target in x.entities] ValueError: If return_type is "id" or "dir", a valid target entity must also be specified.

jdkent · 2019-01-14T00:08:01Z

nipype/interfaces/io.py

-            bids_config = join(dirname(bidslayout.__file__), 'config', 'bids.json')
+            from bids import layout as bidslayout
+            bids_config = join(
+                dirname(bidslayout.__file__), 'config', 'bids.json')
            bids_config = json.load(open(bids_config, 'r'))
            infields = [i['name'] for i in bids_config['entities']]


That command (BIDSLayout().entities) returned an error for me:
TypeError: __init__() missing 1 required positional argument: 'root'.

I do not know of a better way (but I didn't look extremely hard)

Another comment: I think it would be nice to include derivatives.json (or the derivatives entities) by default as well for queries to be maximally flexible.

jdkent · 2019-01-14T00:47:08Z

nipype/interfaces/io.py

+    index_derivatives = traits.Bool(
+        False, usedefault=True,
+        desc='Index derivatives/ sub-directory')
+    extra_derivatives = traits.List(


when using the add_derivatives method, the docstring indicates this can either be a list or a string.

Suggested change

extra_derivatives = traits.List(

extra_derivatives = InputMultiObject(

(Requires importing ImportMultiObject along with InputMultiPath; we should move all *MultiPaths to *MultiObjects, but that shouldn't be this PR.)

adelavega · 2019-01-14T16:35:42Z

Well, I merged master and now some other unrelated tests are failing.. Any clues?

adelavega · 2019-01-14T16:44:29Z

Also, it looks like @jdkent's issue is a more general pybids issue: bids-standard/pybids#343

Also, some derivatives were not being validated because dataset_description.json was missing.

The other issue was deprecated derivatives keys. In the meantime, we can allow some custom keys to be passed in, as you can already do in pybids. I'll look into this.

adelavega · 2019-01-14T17:53:18Z

Cool, looks like tests pass in Python 2 (aside from those failing due to another issue)

effigies · 2019-01-14T18:01:13Z

Yeah, I'm starting to think it's numpy 1.16 that's breaking things somehow.

…ybids

adelavega · 2019-01-18T23:32:28Z

Hey, it works! Do you think it's ready to merge @effigies?

effigies · 2019-01-18T23:45:51Z

Sorry, I still need to get around to a final review.

effigies

I've made some comments, one related to a merge conflict I've just bestowed upon you. Let me know what you think.

A little more broadly, I think we're running up against the problem of backwards compatibility, which is going to be a problem, as @jdkent notes, for people attempting to work with derivatives from fmriprep<1.2.

@jdkent Is it possible that running this interface with bids 0.6.5 gives you the entities you want? If not, is it worth augmenting to support 0.6.5? I'm okay with setting a hard minimum on 0.6.5, so that we have pre-August and post-August BIDS derivatives support without committing to support all the reorganizations that happened before then.

effigies · 2019-01-20T16:34:52Z

docker/generate_dockerfiles.sh

@@ -92,7 +92,7 @@ function generate_main_dockerfile() {
                conda_install='python=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}
                               icu=58.1 libxml2 libxslt matplotlib mkl numpy paramiko
                               pandas psutil scikit-learn scipy traits=4.6.0' \
-                pip_install="grabbit==0.1.2 https://github.com/INCF/pybids/tarball/0.6.5" \
+                pip_install="grabbit==0.2.6 https://github.com/bids-standard/pybids/tarball/0.7.0" \


This is going to have conflicts when #2856 is merged. Also, for tests to work, this will need to be installed in editable mode. Perhaps add https://github.com/bids-standard/pybids/tarball/0.7.0 to L110:

- pip_install="/src/nipype[all]" \ + pip_install="/src/nipype[all] https://github.com/bids-standard/pybids/tarball/0.7.0" \

nipype/info.py

effigies · 2019-01-20T16:36:21Z

nipype/interfaces/io.py

+        True, usedefault=True,
+        desc='Generate exception if list is empty for a given field')
+    return_type = traits.Enum(
+        'file', 'namedtuple', usedefault=True)


You were going to remove namedtuple?

nipype/interfaces/io.py

effigies · 2019-01-20T16:38:59Z

nipype/interfaces/io.py

+    index_derivatives = traits.Bool(
+        False, usedefault=True,
+        desc='Index derivatives/ sub-directory')
+    extra_derivatives = traits.List(


Suggested change

extra_derivatives = traits.List(

extra_derivatives = InputMultiObject(

(Requires importing ImportMultiObject along with InputMultiPath; we should move all *MultiPaths to *MultiObjects, but that shouldn't be this PR.)

Co-Authored-By: adelavega <aleph4@gmail.com>

…te-pybids

Mandatory index_derivatives Co-Authored-By: adelavega <aleph4@gmail.com>

…te-pybids

adelavega · 2019-01-22T16:50:15Z

OK, I addressed all changes except extra_derivatives = InputMultiObject

What's that about? You're saying I should or shouldn't do it in this PR?

adelavega · 2019-01-22T16:52:17Z

Regarding backwards compatibility, I think supporting pybids < 0.7 is more trouble than its worth.

Turns out its just a single key that is causing problems, so perhaps instead we should allow custom keys to be passed in (which pybids allows), and that can be used to read in older fmripep outputs.

This is what @jdkent and I agreed on in Florida. I just wasn't necessarily going to put that into this PR, but I can.

effigies · 2019-01-22T16:56:35Z

What's that about? You're saying I should or shouldn't do it in this PR?

We should allow multiple paths, but changing all MultiPaths in the file to MultiObjects is out-of-scope. I probably shouldn't have mentioned it; it's just that we're moving from one to the other, so new things should be Object instead of Path.

effigies · 2019-01-22T16:57:45Z

Regarding backwards compatibility, I think supporting pybids < 0.7 is more trouble than its worth.

Okay. Hopefully nobody else is using this.

adelavega · 2019-01-22T17:07:31Z

How about if we leave this PR as is (assuming I addressed your others comments and tests pass), and we can address the custom keys argument in another PR? That way @jdkent can test it out (since he has an old fmriprep input he is trying to read in.

effigies · 2019-01-22T17:33:04Z

make specs

adelavega · 2019-01-22T20:19:54Z

Something else unrelated seems to be failing now...

tmpdir = local('/tmp/pytest-of-neuro/pytest-0/popen-gw1/test_split_and_merge0')

effigies · 2019-01-22T20:21:05Z

Merge master.

effigies · 2019-01-22T20:21:56Z

(See #2855.)

adelavega · 2019-01-22T21:57:48Z

It says I'm already up to date on master. I merged master very recently and that PR was 6 days ago.

adelavega · 2019-01-22T21:58:34Z

There was one auto test that didnt get added (new file) so hopefully that's the issue.

effigies · 2019-01-22T22:12:18Z

Nope, it's #2862. Not sure if that will work. We'll see.

adelavega · 2019-01-22T22:15:18Z

Code maintenance is super fun!

@feilong

1.1.8 (January 28, 2019) * FIX: ANTS LaplacianThickness cmdline opts fixed up (nipy#2846) * FIX: Resolve LinAlgError during SVD (nipy#2838) * ENH: Add interfaces wrapping DIPY worflows (nipy#2830) * ENH: Update BIDSDataGrabber for pybids 0.7 (nipy#2737) * ENH: Add FSL `eddy_quad` interface (nipy#2825) * ENH: Support tckgen -select in MRtrix3 v3+ (nipy#2823) * ENH: Support for BIDS event files (nipy#2845) * ENH: CompositeTransformUtil, new ANTs interface (nipy#2785) * RF: Move pytest and pytest-xdist from general requirement into tests_required (nipy#2850) * DOC: Add S3DataGrabber example (nipy#2849) * DOC: Skip conftest module in API generation (nipy#2852) * DOC: Hyperlink DOIs to preferred resolver (nipy#2833) * MAINT: Install numpy!=1.16.0 from conda in Docker (nipy#2862) * MAINT: Drop pytest-xdist requirement, minimum pytest version (nipy#2856) * MAINT: Disable numpy 1.16.0 for Py2.7 (nipy#2855) * tag '1.1.8': (79 commits) MNT: Add @feilong to .zenodo, update ordering MNT: Update .mailmap MNT: Update .zenodo ordering Accept invitation as Zenodo release co-author (see nipy#2864) MAINT: Update .mailmap BF: allowing bids_event_file as alternate input MNT: Update .zenodo ordering MNT: Version 1.1.8 DOC: 1.1.8 changelog Update nipype/interfaces/dipy/tracks.py Update nipype/interfaces/dipy/reconstruction.py MNT: Install numpy!=1.16.0 from conda in Docker Add FSL auto test remake specs Update nipype/interfaces/io.py Remove return type named tuple Update nipype/info.py STY: Whitespace, line length Remove out_ prefix from EddyQuad outputs Apply minor edits from code review ...

adelavega added 3 commits October 9, 2018 09:47

Lock travis Python 0.6.5

ffd0d8e

Merge master

8db5111

Update BIDSDataGrabber for pybids 0.7, including tests, and derivativ…

801b295

…es handling

adelavega mentioned this pull request Oct 15, 2018

[WIP] Update tutorial to use BIDSDataGrabber miykael/nipype_tutorial#131

Merged

3 tasks

Fix test, outfields

1d267c8

effigies reviewed Oct 16, 2018

View reviewed changes

Refer to proper input, index_derivatives

b0121c0

Datatype not modality, in pybids tests

cc89c58

jdkent mentioned this pull request Dec 8, 2018

[ENH] add option to include derivatives in BIDSDataGrabber #2815

Closed

1 task

effigies added this to the 1.1.8 milestone Dec 14, 2018

adelavega changed the title ~~[WIP] Update BIDSDataGrabber for pybids 0.7~~ [ENH] Update BIDSDataGrabber for pybids 0.7 Dec 14, 2018

adelavega added 4 commits January 11, 2019 13:42

Merge master

b8aacce

Lint BIDSGrabbder

a0e92f1

Bump pybids version to 0.7.0

0f94d9d

use https for travis pybids requirement

77a0510

effigies reviewed Jan 13, 2019

View reviewed changes

jdkent reviewed Jan 14, 2019

View reviewed changes

Merge branch 'master' into update-pybids

26a57a6

Merge branch 'master' into update-pybids

2a84cab

Re-enable editable mode, and run tests in Python 2

5590d4d

Merge branch 'master' of https://github.com/nipy/nipype into update-p…

3c21466

…ybids

effigies mentioned this pull request Jan 20, 2019

MAINT: Drop pytest-xdist requirement, minimum pytest version #2856

Merged

5 tasks

effigies reviewed Jan 20, 2019

View reviewed changes

adelavega and others added 6 commits January 22, 2019 10:44

Merge master and fix merge conflict

d2e53fb

Update nipype/info.py

b75bf7c

Co-Authored-By: adelavega <aleph4@gmail.com>

Remove return type named tuple

7105cb5

Merge branch 'update-pybids' of github.com:adelavega/nipype into upda…

09a1a43

…te-pybids

Update nipype/interfaces/io.py

75a5a2b

Mandatory index_derivatives Co-Authored-By: adelavega <aleph4@gmail.com>

Merge branch 'update-pybids' of github.com:adelavega/nipype into upda…

139c163

…te-pybids

remake specs

b623cdd

Add FSL auto test

aeda06a

effigies mentioned this pull request Jan 22, 2019

MNT: Install numpy!=1.16.0 from conda in Docker #2862

Merged

1 task

effigies merged commit 80dfc86 into nipy:master Jan 23, 2019

adelavega deleted the update-pybids branch January 23, 2019 02:21

	extra_derivatives = traits.List(
	extra_derivatives = InputMultiObject(

[ENH] Update BIDSDataGrabber for pybids 0.7 #2737

[ENH] Update BIDSDataGrabber for pybids 0.7 #2737

Conversation

adelavega commented Oct 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 16, 2018 • edited Loading

Codecov Report

adelavega commented Oct 16, 2018

effigies commented Dec 14, 2018

adelavega commented Dec 14, 2018

adelavega commented Jan 11, 2019

effigies commented Jan 13, 2019 • edited Loading

effigies left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdkent Jan 13, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdkent Jan 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdkent left a comment

Choose a reason for hiding this comment

jdkent Jan 13, 2019 • edited Loading

Choose a reason for hiding this comment

jdkent Jan 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adelavega commented Jan 14, 2019

adelavega commented Jan 14, 2019

adelavega commented Jan 14, 2019

effigies commented Jan 14, 2019 • edited Loading

adelavega commented Jan 18, 2019

effigies commented Jan 18, 2019

effigies left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adelavega commented Jan 22, 2019

adelavega commented Jan 22, 2019

effigies commented Jan 22, 2019

effigies commented Jan 22, 2019

adelavega commented Jan 22, 2019

effigies commented Jan 22, 2019

adelavega commented Jan 22, 2019

effigies commented Jan 22, 2019

effigies commented Jan 22, 2019

adelavega commented Jan 22, 2019

adelavega commented Jan 22, 2019

effigies commented Jan 22, 2019

adelavega commented Jan 22, 2019

adelavega commented Oct 15, 2018 •

edited

Loading

codecov-io commented Oct 16, 2018 •

edited

Loading

effigies commented Jan 13, 2019 •

edited

Loading

jdkent Jan 13, 2019 •

edited

Loading

jdkent Jan 14, 2019 •

edited

Loading

jdkent Jan 13, 2019 •

edited

Loading

jdkent Jan 14, 2019 •

edited

Loading

effigies commented Jan 14, 2019 •

edited

Loading