[FIX] Fixed a small bug in freesurfer label2annot fill_thresh specs #2377
Conversation
|
Please merge master, run |
bring branch up to date
|
@achetverikov - just checking to see if you can:
|
|
will do, at least will try to |
|
Hi @achetverikov do you have a second to give this a shot? Just to be explicit about what I was suggesting:
git remote add upstream https://github.com/nipy/nipype.git
git fetch upstream
git merge upstream/master
make specs
git add nipype/interfaces/freesurfer/tests/*
git commit -m 'TEST: make specs'
git push |
|
OK, done. Thanks for the detailed instructions, @effigies . |
| @@ -1,6 +1,6 @@ | |||
| # AUTO-GENERATED by tools/checkspecs.py - DO NOT EDIT | |||
| from __future__ import unicode_literals | |||
| from ..model import Binarize | |||
| from ..model_bkp import Binarize | |||
There was a problem hiding this comment.
Something seems to have gone wrong. I'm guessing model_bkp.py is a backup file you have in your local repository? That's interfering with the proper behavior of make specs. Could you remove it, re-run make specs and add the updated auto tests?
There was a problem hiding this comment.
Ah, right. I forgot that I made a backup and was looking at the error message with no clue to what's going on. I did as you suggested, hope that will work.
Codecov Report
@@ Coverage Diff @@
## master #2377 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 328 328
Lines 42551 42551
Branches 5276 5276
=======================================
Hits 28366 28366
Misses 13505 13505
Partials 680 680
Continue to review full report at Codecov.
|
| @@ -1144,7 +1144,7 @@ class Label2VolInputSpec(FSTraitedSpec): | |||
| invert_mtx = traits.Bool( | |||
| argstr='--invertmtx', desc='Invert the registration matrix') | |||
| fill_thresh = traits.Range( | |||
| 0., 1., argstr='--fillthresh %.f', desc='thresh : between 0 and 1') | |||
| 0., 1., argstr='--fillthresh %f', desc='thresh : between 0 and 1') | |||
There was a problem hiding this comment.
Let's go ahead and change this to %g (and remake auto tests).
Also, in the Label2Vol docstring, you'll need to change --fillthresh 0 to --fillthresh 0.5.
|
Hi @achetverikov, do you have a couple minutes to finish this off? I think it's just about done. |
…chetverikov/nipype into freesurfer_model_label2vol_fix
|
right, I added the changes you suggested merged with master again, ran make specs, and so on |
Fixes a small bug in freesurfer label2annot fill_thresh specs (should be %f instead of %.f)