Move about nav to the final position, trim the copy #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
requested changes
Dec 19, 2021
There was a problem hiding this comment.
This is exacerbating #500; when we are using url we need to make sure that it exactly matches page.url (https://jekyllrb.com/tutorials/navigation/#scenario-6-applying-the-active-class-for-the-current-page)
I'm fine with moving this to the final position, and I'm ok with shortening to "About" :)
|
@krassowski, the underlying fix you wanted has been merged. So I think this is again ready for your review. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final nav position is, on many many sites, the position for slotting the about page. The copy can also be a little shorter and be just fine. This is another small step to shave things to the tightest possible nav for #433.