Skip to content

Active tab highlighting is not consistent in the navigation bar #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krassowski opened this issue Dec 19, 2021 · 4 comments · Fixed by #504 or #585
Closed

Active tab highlighting is not consistent in the navigation bar #500

krassowski opened this issue Dec 19, 2021 · 4 comments · Fixed by #504 or #585

Comments

@krassowski
Copy link
Member

It seems that recent refactoring might have broken highlighting of the active page in the navigation tab:

active-page-not-highighted

It works well for About us, Documentation, and Widgets but not for the other tabs in the nav bar.

@krassowski krassowski added the bug label Dec 19, 2021
@palewire
Copy link
Collaborator

palewire commented Dec 19, 2021

Could we fix this by using the URL, not the page title, in the loop test here?

@krassowski
Copy link
Member Author

Yes, this looks like a good idea. Or maybe we could test both (with or operator)?

@krassowski
Copy link
Member Author

It looks like it is happening again?

@palewire palewire reopened this Dec 30, 2021
@palewire
Copy link
Collaborator

I probably screwed it up when I refactored the nav. Will look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants