Skip to content

feat(textarea): add experimental label slot #27677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 20, 2023
Merged

feat(textarea): add experimental label slot #27677

merged 24 commits into from
Jun 20, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 20, 2023 •
edited
Loading

Issue number: resolves #27061

What is the current behavior?

Textarea does not accept custom HTML labels

What is the new behavior?

  • Textarea accepts custom HTML labels as an experimental feature. We marked this as experimental because it makes use of "scoped slots" which is an emulated version of Web Component slots. As a result, there may be instances where the slot behavior does not exactly match the native slot behavior.

Note to reviewers: This is a combination of previously reviewed PRs. The implementation is complete, so feel free to bikeshed.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Docs PR: ionic-team/ionic-docs#3001

liamdebeasi and others added 22 commits June 12, 2023 09:06
@liamdebeasi
feat(input): add base label slot implementation
5f83994
@liamdebeasi
test(input): update tests
514b677
@Ionitron
chore(): add updated snapshots
de1f128
@liamdebeasi
test(input): add spec and a11y tests
1f867f2
@liamdebeasi
note feature is experimental
5618a55
@liamdebeasi
feat: add bae slot mutation observer
a343c37
@liamdebeasi
add base slot mutation observer impl
a905a91
@liamdebeasi
clean up code
03d4032
@liamdebeasi
add test
f0da048
@liamdebeasi
feat(input): add label slot (#27633)
1188234
@Ionitron
chore(): add updated snapshots
b66a627
@liamdebeasi
feat(input): support notch with label slot (#27635)
71b0214
@liamdebeasi
sync
d36c413
@liamdebeasi
update test for outline notch
126ae3e
@liamdebeasi
listen for changes to slotted content itself
d48a950
@liamdebeasi
add correct usage check
b02d1cc
@liamdebeasi
update file location
b66bd8d
@liamdebeasi
lint
cea8a22
@liamdebeasi
feat(textarea): add label slot (#27647)
5a35918
@liamdebeasi
chore(): sync
2698d43
@liamdebeasi
Merge remote-tracking branch 'origin/feature-7.1' into FW-4409
c2dffd0
@liamdebeasi
feat(textarea): support notch with label slot (#27660)
884fecd
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 20, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review June 20, 2023 20:00
@liamdebeasi liamdebeasi merged commit 8bcd9e8 into feature-7.1 Jun 20, 2023
@liamdebeasi liamdebeasi deleted the FW-4409 branch June 20, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liamdebeasi @brandyscarney @Ionitron