Skip to content

feat(textarea): add label slot #27647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 15, 2023
Merged

feat(textarea): add label slot #27647

merged 10 commits into from
Jun 15, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 14, 2023 •
edited
Loading

Issue number: N/A

What is the current behavior?

Textarea only accepts plaintext labels.

What is the new behavior?

  • Textarea can now accept custom HTML labels via a slot

A few implementation notes:

  • Support for dynamically adding/removing slotted content will be added in a separate PR.
  • Support for the notch outline will be added in a separate PR.
  • The existing start/end placement label overflow tests were made redundant with the new tests I added. As a result, I removed the old tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 14, 2023
@liamdebeasi liamdebeasi changed the title 4409 base feat(textarea): add label slot Jun 14, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review June 14, 2023 16:58
@liamdebeasi liamdebeasi requested review from a team, thetaPC and brandyscarney and removed request for a team June 14, 2023 16:58
@liamdebeasi liamdebeasi mentioned this pull request Jun 14, 2023
Merged
2 tasks
thetaPC
thetaPC approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brandyscarney
brandyscarney approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the notch outline calculation which will be done in a separate PR. 👍

liamdebeasi and others added 3 commits June 15, 2023 09:01
@liamdebeasi @brandyscarney
Update core/src/components/textarea/test/label-placement/textarea.e2e.ts
6cf3fc1 
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi @brandyscarney
Update core/src/components/textarea/test/label-placement/textarea.e2e.ts
8fe23e6 
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi
fix experimental docs
de54350
@liamdebeasi liamdebeasi merged commit 5a35918 into FW-4409 Jun 15, 2023
@liamdebeasi liamdebeasi deleted the 4409-base branch June 15, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamdebeasi @brandyscarney @thetaPC @Ionitron