merge with fb upstream cra 4.0 #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebmshafer
approved these changes
Oct 24, 2020
There was a problem hiding this comment.
LGTM, thanks for picking this up @aruniverse!
Let's get this merged in and we can start testing it out with 4.0.0-beta.0 package. I'm interested to try out the new FAST_REFRESH in the iModel.js repo and see how it works.
Also, we'll want to make sure we do a real merge commit instead of a squash commit.
|
@aruniverse I'll merge upstream master into our master branch now. Plus open the PR for updating the docs to match what I outlined in #8. |
|
Updated the |
|
Abandoning in favor of #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.