Skip to content

Sync/cra 4.0 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 178 commits into from
Closed

Sync/cra 4.0 #24

wants to merge 178 commits into from

Conversation

aruniverse
Copy link
Member

@aruniverse aruniverse commented Nov 5, 2020 •
edited
Loading

Syncing fork with upstream 4.0 release

only conflicts were with the following files:

  • packages\react-scripts\package.json
  • packages\react-scripts\config\webpack.config.js
  • packages\react-scripts\scripts\build.js
  • packages\react-scripts\scripts\utils\createJestConfig.js

MichaelDeBoey and others added 30 commits March 24, 2020 09:10
@MichaelDeBoey
Update template tests (facebook#8705)
79dbc33
@braedongough
Bump TypeScript template to 3.8 (facebook#8713)
edc671e
@ai
Add .cjs and .mjs files support to test runner (facebook#8768)
bc41892
@Dremora
Use simplified import of @testing-library/jest-dom (facebook#8763)
56d34c0
@iddan
Include absoluteRuntime in babel preset docs (facebook#5847)
c7352c7
@challet
Specify what files are served form a bare local copy (facebook#8749)
4cbb003
@mrmckeb
fix: handle templates without main package field (facebook#8734)
e0b179c
@charrondev @ianschmitz
Add experimental react-refresh support (facebook#8582)
c5b96c2 
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
@MostafaNawara
Add setupTests.js to the list of generated files (facebook#8791)
53cace5
@coryhouse
Simplify wording in setting-up-your-editor.md (facebook#8684)
f0f4d5b
@M165437
Update url to see prettier in action (facebook#8610)
d80e533
@dependabot
Bump acorn from 6.4.0 to 6.4.1 in /docusaurus/website (facebook#8656)
a4fa63f 
Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@6.4.0...6.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sebmarkbage
Don't use webpack multi entry unnecessarily (facebook#8834)
e89f153 
Passing an array with a single entry is not equivalent. This causes Webpack
to generate another wrapper module around the entry. This is just
unnecessary overhead and bytes.
@NMinhNguyen
Widen eslint-config-react-app peer dependency versions (facebook#8892)
855a984 
See facebook#7790 for a previous similar PR.
@gaearon
Revert "Replace favicon in templates (facebook#8194)" (facebook#8925)
3771237 
This reverts commit c03bb36.
@ianschmitz
Minor/patch dependency upgrades (facebook#8947)
9cc1bdf
@skovhus @ianschmitz
Upgrade to Jest 25 (facebook#8362)
9904075 
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
@ianschmitz
Drop Node 8 support (facebook#8948)
8b0d21f
@gaearon
Bump React Hooks ESLint plugin to 4.0.0 (facebook#8939)
fa93437
@StenAL
Update build script deployment URL (facebook#8651)
99f1b6b
@jeremywadsack
Do not check for interactive session to shut down dev server (faceboo…
2975939 
…k#8845)
@mkorostoff
Support source maps for scss in dev environments (facebook#8638)
b37cff9
@hieuxlu
Skip stdin resuming to support lerna parallel (facebook#8700)
790fba9
@alexkrolick
Set resetMocks to true by default in jest config (facebook#7899)
4974a20
@shakib609
Add import/no-anonymous-default-export lint rule (facebook#8926)
3c2f2d4
@gnapse @ianschmitz
Upgrade testing-library packages (facebook#8406)
5d437b8 
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
@chybisov
Bump style-loader to 1.2.1 (facebook#8891)
5a019e6
@mrmckeb
Support devDependencies in templates (facebook#8838)
2473a73
@tanhauhau
fix react-refresh babel plugin not applied (facebook#8952)
62e8e3d
@maazadeeb
Add a VSCode tip in the CSS reset section (facebook#8246)
6a7aaa2
@aruniverse
Copy link
Member Author

aruniverse commented Dec 24, 2020 •
edited
Loading

Found a bug... For some reason in my itwin-viewer test app, im not seeing __IMODELJS_INTERNALS_DO_NOT_USE, and looking at the webpack.config I do see the IModeljsLibraryExportsPlugin being used. Need to investigate further

@aruniverse
Copy link
Member Author

Found a bug... For some reason in my itwin-viewer test app, im not seeing __IMODELJS_INTERNALS_DO_NOT_USE, and looking at the webpack.config I do see the IModeljsLibraryExportsPlugin being used. Need to investigate further

NVM, disregard this. My sample app had both our bentley fork and the fb react-scripts as dev deps, and when i was running the app it defaulted to using the fb one, and thats why the imjs globals were missing.

@aruniverse aruniverse mentioned this pull request Jan 11, 2021
Closed
merceyz and others added 23 commits January 13, 2021 16:07
@merceyz
fix(react-scripts): add missing peer dependency react and update reac…
a504e9d 
…t-refresh-webpack-plugin (facebook#9872)
@Avivhdr
Update using-the-public-folder.md (facebook#10314)
0f6fc2b 
Some library --> Some libraries
@tobiasbueschel
docs: add missing override options for Jest config (facebook#9473)
c9a24db
@ianschmitz
Fix CI tests (facebook#10217)
d229676
@josezone @mad-jose
appTsConfig immutability handling by immer (facebook#10027)
6a39607 
Co-authored-by: mad-jose <joset@yeswearemad.com>
@ajhyndman
Add support for new BUILD_PATH advanced configuration variable (faceb…
8fa0a26 
…ook#8986)
@mrmckeb
Add opt-out for eslint-webpack-plugin (facebook#10170)
b9963ab
@iansu
Prepare 4.0.2 release
32c06e6
@iansu
Publish
9c75260 
 - cra-template-typescript@1.1.2
 - cra-template@1.1.2
 - create-react-app@4.0.2
 - react-dev-utils@11.0.2
 - react-error-overlay@6.0.9
 - react-scripts@4.0.2
@jamesgeorge007
tests: update test case to match the description (facebook#10384)
3f5dea9
@Awarua-
Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312)
9722ef1 
Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs
@mrmckeb
Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590)
18b5962
@wclem4
update immer to 8.0.1 to address vulnerability (facebook#10412)
6947896 
Resolves facebook#10411

Bumps immer version to 8.0.1 to address the prototype pollution
vulnerability with the current 7.0.9 version.
@iansu
Prepare 4.0.3 release
f710976
@iansu
Update CHANGELOG
cce32fa
@iansu
Publish
f92c37a 
 - create-react-app@4.0.3
 - react-dev-utils@11.0.3
 - react-scripts@4.0.3
@aruniverse
Merge branch 'master' into sync/CRA_4.0
8ae739c
@aruniverse
bump ts-jest to be compatible with jest 26
c3c667a
@aruniverse
add back svgr
aee74f4
@aruniverse
Merge branch 'imodeljs' into sync/CRA_4.0
aebf533
@aruniverse
bad merge, add back fast refresh webpack plugin
abd9093
@aruniverse
Merge branch 'imodeljs' into sync/CRA_4.0
f5c40fb
@aruniverse
depend on sass (dart-sass) ourselves
553795b
@aruniverse
Copy link
Member Author

close in favor of #35

@aruniverse aruniverse closed this Mar 9, 2021
@calebmshafer calebmshafer deleted the sync/CRA_4.0 branch June 28, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

@jason-crow jason-crow Awaiting requested review from jason-crow

@wgoehrig wgoehrig Awaiting requested review from wgoehrig wgoehrig is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.