Skip to content

Fix data stream creation refresh #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

Fix data stream creation refresh #47

merged 1 commit into from
May 30, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented May 30, 2024 •
edited
Loading

There's no reason to refresh after creating an index or data stream, as long as it was acknowledged. If it's not acknowledged, I would expect a timeout. (And we do have timeouts that need to be fixed, by the way.)

Fixes the following error:

ERROR test_elasticsearch_serverless/test_async/test_server/test_helpers.py::TestAsyncDataStreamReindex::test_reindex_index_datastream_op_type_index - TypeError: IndicesClient.create_data_stream() got an unexpected keyword argument 'refresh'

@pquentin pquentin requested a review from miguelgrinberg May 30, 2024 10:18
@pquentin pquentin merged commit 1b337ed into elastic:main May 30, 2024
9 of 10 checks passed
@pquentin pquentin deleted the data-stream-refresh branch May 30, 2024 16:32
@pquentin pquentin mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgrinberg miguelgrinberg miguelgrinberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @miguelgrinberg