Skip to content

[release/7.0] Don't generate RequestBody for parameters when disabledInferredBody is true #47807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

[release/7.0] Don't generate RequestBody for parameters when disabledInferredBody is true #47807

merged 1 commit into from
May 8, 2023

Conversation

captainsafia
Copy link
Member

Description

The disableInferredBody configuration was not respected when generating the specification for the RequestBody in the OpenAPI generator.

Fixes #47644

Customer Impact

Without this bug fix, incorrect OpenAPI documents are produced for scenarios where customers are using certain parameter types in non-POST requests.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

The impact area of the bug is localized (WithOpenApi + minimal APIs) so the risk is low.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@captainsafia captainsafia requested a review from a team as a code owner April 20, 2023 17:24
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 20, 2023
@ghost ghost added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Apr 20, 2023
@ghost ghost added this to the 7.0.x milestone Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Hi @captainsafia. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@captainsafia captainsafia added Servicing-consider Shiproom approval is required for the issue feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@captainsafia captainsafia changed the title Don't generate RequestBody for parameters when disabledInferredBody is true [release/7.0] Don't generate RequestBody for parameters when disabledInferredBody is true Apr 20, 2023
@captainsafia captainsafia mentioned this pull request Apr 20, 2023
Closed
1 task
@ghost
Copy link

ghost commented May 4, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 4, 2023
@captainsafia
Copy link
Member Author

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 4, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia
Copy link
Member Author

Approved via email.

@captainsafia captainsafia added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Hi @captainsafia. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@wtgodbe wtgodbe merged commit 5c0d5a9 into release/7.0 May 8, 2023
@wtgodbe wtgodbe deleted the safia/bp-woa-fix branch May 8, 2023 18:42
@ghost ghost modified the milestones: 7.0.x, 7.0.7 May 8, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-openapi Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
7.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@captainsafia @BrennanConroy @wtgodbe